As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 755631 - Extraneous Exceptions in Cross Origin Wrappers
: Extraneous Exceptions in Cross Origin Wrappers
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Devdatta Akhawe [:devd]
: Andrew Overholt [:overholt]
Depends on:
  Show dependency treegraph
Reported: 2012-05-15 23:05 PDT by Devdatta Akhawe [:devd]
Modified: 2012-05-26 15:27 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Remove some of the exceptions (693 bytes, patch)
2012-05-16 10:32 PDT, Devdatta Akhawe [:devd]
mrbkap: review+
Details | Diff | Splinter Review

Description User image Devdatta Akhawe [:devd] 2012-05-15 23:05:54 PDT
The current mozilla-central/js/xpconnect/wrappers/AccessCheck.cpp file's function 'IsPermitted' special cases DOMException and Error objects as permitted for cross origin access. It is not clear if they are necessary; and since they essentially look like exceptions to the same-origin policy, it might make sense to remove these.
Comment 1 User image Devdatta Akhawe [:devd] 2012-05-16 10:32:18 PDT
Created attachment 624441 [details] [diff] [review]
Remove some of the exceptions
Comment 2 User image Blake Kaplan (:mrbkap) 2012-05-22 16:02:56 PDT
Comment on attachment 624441 [details] [diff] [review]
Remove some of the exceptions

Comment 3 User image :Ms2ger (⌚ UTC+1/+2) 2012-05-23 09:24:24 PDT
Pushed manually...
Comment 4 User image :Ms2ger (⌚ UTC+1/+2) 2012-05-25 03:33:12 PDT
Looks good
Comment 5 User image Ryan VanderMeulen [:RyanVM] 2012-05-26 06:39:51 PDT

Thanks for the patch, dev! One request - for future patches, please follow the directions below so that it contains all the required metadata for checkin. It makes life easier for those checking in on your behalf. Thanks!
Comment 6 User image Ryan VanderMeulen [:RyanVM] 2012-05-26 15:27:34 PDT

Note You need to log in before you can comment on or make changes to this bug.