755631 - Extraneous Exceptions in Cross Origin Wrappers

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Devdatta Akhawe [:devd]]

The current mozilla-central/js/xpconnect/wrappers/AccessCheck.cpp file's function 'IsPermitted' special cases DOMException and Error objects as permitted for cross origin access. It is not clear if they are necessary; and since they essentially look like exceptions to the same-origin policy, it might make sense to remove these.

Comment 1

[Devdatta Akhawe [:devd]]

Attachment: Remove some of the exceptions

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 624441 [details] [diff] [review]
Remove some of the exceptions

Thanks!

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Pushed manually...

https://tbpl.mozilla.org/?tree=Try&rev=51c09d99bc77

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Looks good

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae9977a419c9

Thanks for the patch, dev! One request - for future patches, please follow the directions below so that it contains all the required metadata for checkin. It makes life easier for those checking in on your behalf. Thanks!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ae9977a419c9