The default bug view has changed. See this FAQ.

Extraneous Exceptions in Cross Origin Wrappers

RESOLVED FIXED in mozilla15

Status

()

Core
XPConnect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: devd, Assigned: devd)

Tracking

Trunk
mozilla15
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The current mozilla-central/js/xpconnect/wrappers/AccessCheck.cpp file's function 'IsPermitted' special cases DOMException and Error objects as permitted for cross origin access. It is not clear if they are necessary; and since they essentially look like exceptions to the same-origin policy, it might make sense to remove these.
Component: DOM → XPConnect
OS: Windows 7 → All
QA Contact: general → xpconnect
Hardware: x86_64 → All
Version: unspecified → Trunk
(Assignee)

Comment 1

5 years ago
Created attachment 624441 [details] [diff] [review]
Remove some of the exceptions

Updated

5 years ago
Attachment #624441 - Flags: review?(mrbkap)
Comment on attachment 624441 [details] [diff] [review]
Remove some of the exceptions

Thanks!
Attachment #624441 - Flags: review?(mrbkap) → review+

Updated

5 years ago
Assignee: nobody → dev.akhawe
Status: NEW → ASSIGNED
Whiteboard: [autoland-try]
Pushed manually...

https://tbpl.mozilla.org/?tree=Try&rev=51c09d99bc77
Whiteboard: [autoland-try]
Looks good
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae9977a419c9

Thanks for the patch, dev! One request - for future patches, please follow the directions below so that it contains all the required metadata for checkin. It makes life easier for those checking in on your behalf. Thanks!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/ae9977a419c9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.