755636 - Implement a dom::Sequence for sequence arguments, so that we don't have to expose details about fallibility and auto-arrayness.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Convert sequence argument codegen to dom::Sequence.

There is a part 2 coming up which adds some tests and fixes the various sequence codegen bugs those tests uncovered.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Note that the XXXbz comment is part of what part 2 will need to deal with...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 624975 [details] [diff] [review]
part 1.  Convert sequence argument codegen to dom::Sequence.

And actually, I think I can make this better.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Convert sequence argument codegen to dom::Sequence.

OK, this is a bit better.  Please do let me know whether you prefer the holder approach here or the Constifier approach from the first patch?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Part 1 with the nullable case actually compiling

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Part 1 with some comments fixed too

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Add some tests (not exhaustive!) for sequence codegen and fix the bugs they uncover.

Comment 8

[Peter Van der Beken [:peterv]]

Comment on attachment 625211 [details] [diff] [review]
Part 1 with some comments fixed too

Review of attachment 625211 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContextGL.cpp
@@ +4442,5 @@
>      return NS_OK;                                                               \
>  }                                                                               \
>  void                                                                            \
>  WebGLContext::name##_base(WebGLUniformLocation *location_object,                \
> +                        uint32_t arrayLength, const ptrType* data) {                  \

Line up \ (here and in the other lines you changed).

Comment 9

[Boris Zbarsky [:bzbarsky]]

> Line up \ (here and in the other lines you changed).

Done.

Comment 10

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/mozilla-central/rev/9d354b418ea7
http://hg.mozilla.org/mozilla-central/rev/9f4b10b1ff45