Implement a dom::Sequence for sequence arguments, so that we don't have to expose details about fallibility and auto-arrayness.

RESOLVED FIXED in mozilla15

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug)

unspecified
mozilla15
x86
Mac OS X
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

Created attachment 624975 [details] [diff] [review]
part 1.  Convert sequence argument codegen to dom::Sequence.

There is a part 2 coming up which adds some tests and fixes the various sequence codegen bugs those tests uncovered.
Attachment #624975 - Flags: review?(peterv)
Note that the XXXbz comment is part of what part 2 will need to deal with...
Comment on attachment 624975 [details] [diff] [review]
part 1.  Convert sequence argument codegen to dom::Sequence.

And actually, I think I can make this better.
Attachment #624975 - Flags: review?(peterv) → review-
Created attachment 625013 [details] [diff] [review]
part 1.  Convert sequence argument codegen to dom::Sequence.

OK, this is a bit better.  Please do let me know whether you prefer the holder approach here or the Constifier approach from the first patch?
Attachment #625013 - Flags: review?(peterv)
Created attachment 625015 [details] [diff] [review]
Part 1 with the nullable case actually compiling
Attachment #625015 - Flags: review?(peterv)
Attachment #625013 - Attachment is obsolete: true
Attachment #625013 - Flags: review?(peterv)
Created attachment 625211 [details] [diff] [review]
Part 1 with some comments fixed too
Attachment #625211 - Flags: review?(peterv)
Attachment #625015 - Attachment is obsolete: true
Attachment #625015 - Flags: review?(peterv)
Attachment #624975 - Attachment is obsolete: true
Created attachment 625212 [details] [diff] [review]
part 2.  Add some tests (not exhaustive!) for sequence codegen and fix the bugs they uncover.
Attachment #625212 - Flags: review?(peterv)
Depends on: 755080
Whiteboard: [need review]
Comment on attachment 625211 [details] [diff] [review]
Part 1 with some comments fixed too

Review of attachment 625211 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContextGL.cpp
@@ +4442,5 @@
>      return NS_OK;                                                               \
>  }                                                                               \
>  void                                                                            \
>  WebGLContext::name##_base(WebGLUniformLocation *location_object,                \
> +                        uint32_t arrayLength, const ptrType* data) {                  \

Line up \ (here and in the other lines you changed).
Attachment #625211 - Flags: review?(peterv) → review+
> Line up \ (here and in the other lines you changed).

Done.
Attachment #625212 - Flags: review?(peterv) → review+
http://hg.mozilla.org/mozilla-central/rev/9d354b418ea7
http://hg.mozilla.org/mozilla-central/rev/9f4b10b1ff45
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [need review]
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.