Last Comment Bug 755768 - IonMonkey: Fix script use count when both Ion and JM are enabled
: IonMonkey: Fix script use count when both Ion and JM are enabled
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Jan de Mooij [:jandem] (PTO until July 31)
:
Mentors:
Depends on:
Blocks: IonMonkey
  Show dependency treegraph
 
Reported: 2012-05-16 08:36 PDT by Jan de Mooij [:jandem] (PTO until July 31)
Modified: 2012-05-16 11:33 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (2.89 KB, patch)
2012-05-16 08:57 PDT, Jan de Mooij [:jandem] (PTO until July 31)
dvander: review+
Details | Diff | Splinter Review

Description Jan de Mooij [:jandem] (PTO until July 31) 2012-05-16 08:36:53 PDT
There are some problems if both Ion and JM+TI are enabled, for instance both compilers call script->incUseCount(), so scripts are compiled after ~20 iterations instead of ~40.
Comment 1 Jan de Mooij [:jandem] (PTO until July 31) 2012-05-16 08:57:54 PDT
Created attachment 624400 [details] [diff] [review]
Patch

The problem with the patch in bug 724751 was that the CanMethodJIT copy in MethodJIT-inl.h was unused (bug 752015 removed the file).
Comment 2 Jan de Mooij [:jandem] (PTO until July 31) 2012-05-16 11:33:07 PDT
https://hg.mozilla.org/projects/ionmonkey/rev/c92b2f714cea

Note You need to log in before you can comment on or make changes to this bug.