Last Comment Bug 755778 - [jsdbg2] Debugger.Environment.prototype.type never returns 'with'
: [jsdbg2] Debugger.Environment.prototype.type never returns 'with'
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Jim Blandy :jimb
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks: 755787
  Show dependency treegraph
 
Reported: 2012-05-16 09:07 PDT by Jim Blandy :jimb
Modified: 2012-05-16 19:54 PDT (History)
3 users (show)
jimb: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Debugger.Environment.prototype.with should return "with" for 'with' statements' environments. (1.76 KB, patch)
2012-05-16 09:15 PDT, Jim Blandy :jimb
jorendorff: review+
Details | Diff | Splinter Review

Description Jim Blandy :jimb 2012-05-16 09:07:14 PDT
According to the spec, the 'type' property of an environment for a 'with' statement is "with". However, the current implementation only ever returns "declarative" or "object"; 'with' statements get the latter.
Comment 1 Jim Blandy :jimb 2012-05-16 09:15:32 PDT
Created attachment 624408 [details] [diff] [review]
Debugger.Environment.prototype.with should return "with" for 'with' statements' environments.

Short and sweet.
Comment 2 Jason Orendorff [:jorendorff] 2012-05-16 09:16:20 PDT
Comment on attachment 624408 [details] [diff] [review]
Debugger.Environment.prototype.with should return "with" for 'with' statements' environments.

Sweet. Thanks.
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-05-16 19:54:13 PDT
https://hg.mozilla.org/mozilla-central/rev/2e7bd3c9bbb5

Note You need to log in before you can comment on or make changes to this bug.