release_sanity.py shouldn't fail on blank lines

RESOLVED WONTFIX

Status

Release Engineering
Release Automation
P3
normal
RESOLVED WONTFIX
6 years ago
3 years ago

People

(Reporter: coop, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [release][sanity])

(Reporter)

Description

6 years ago
We had problems running release_sanity.py during Firefox 13.0b4 because of an extraneous blank line at the end of the l10n changesets file. Our scripts should be smart enough to ignore blank lines.
Agreed. Lower priority than other work, though.
Priority: -- → P3
Looked into this a bit, I think we should make the 'compare' method capable of optionally ignoring leading/trailing whitespace: https://github.com/mozilla/build-tools/blob/master/lib/python/util/file.py#L5.
(Assignee)

Updated

5 years ago
Product: mozilla.org → Release Engineering
Ship it truncates input data, so this probably isn't worthwhile to fix anymore.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.