Use even lower precision bilinear interpolation when scaling 565 to 565

RESOLVED FIXED in Firefox 14

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla15
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox14 fixed, blocking-fennec1.0 soft)

Details

Attachments

(1 attachment)

5.02 KB, patch
Joe Drew (not getting mail)
: review+
Joe Drew (not getting mail)
: approval-mozilla-aurora+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 624452 [details] [diff] [review]
Use skia style fastness
Attachment #624452 - Flags: review?(joe)
Comment on attachment 624452 [details] [diff] [review]
Use skia style fastness

Review of attachment 624452 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Please prove try pass for greater clarity

::: gfx/cairo/libpixman/src/pixman-fast-path.c
@@ +1301,5 @@
> +   This gives us 5 extra bits of space before each component to let us do
> +   SWAR style optimizations
> +*/
> +
> +#define GREEN_MASK (((1<<6)-1)<<5)

Can you add spaces here for greater clarity

@@ +1327,2 @@
>  
> +    xy = x * y >> 3;

Can you parenthesize here for greater clarity

@@ +1351,5 @@
>  	uint16_t tr = src_top [pixman_fixed_to_int (vx) + 1];
>  	uint16_t bl = src_bottom [pixman_fixed_to_int (vx)];
>  	uint16_t br = src_bottom [pixman_fixed_to_int (vx) + 1];
>  
> +        uint16_t d = bilinear_interpolation_565 (tl, tr, bl, br, (vx>>12)&0xf, wb>>4);

Can you add spaces here for greater clarity
Attachment #624452 - Flags: review?(joe) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd62921a71d8
Assignee: nobody → jmuizelaar
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/fd62921a71d8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
(Assignee)

Comment 4

5 years ago
Comment on attachment 624452 [details] [diff] [review]
Use skia style fastness

[Approval Request Comment]
User impact if declined: The performance improvement at the right side of this chart:
http://graphs.mozilla.org/graph.html#tests=[[201,63,20],[175,63,20]]&sel=none&displayrange=7&datatype=running
Testing completed (on m-c, etc.): has been on m-c for a couple of days
Risk to taking this patch (and alternatives if risky): Mobile and relatively low risk. Any problems would lead to noticeable rendering artifacts
String or UUID changes made by this patch: None
Attachment #624452 - Flags: approval-mozilla-aurora?
This applies only to non-NEON devices like Tegra; NEON-using devices take a different path.

Updated

5 years ago
blocking-fennec1.0: --- → ?
blocking-fennec1.0: ? → soft
Attachment #624452 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/a4080bb8c16e
status-firefox14: --- → fixed
You need to log in before you can comment on or make changes to this bug.