plugin stream decomtamination: nsIPluginStreamListener

RESOLVED FIXED in mozilla15

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

50.18 KB, patch
Benjamin Smedberg
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 624596 [details] [diff] [review]
fix v1.0

nsIPluginStreamListener is unnecessary and complicates our stream handling. We can simplify things by removing it. The trickiest part is that we use QI to figure out what type of stream data we put in NPStream's 'ndata' field. With my patch we always use the same type of stream wrapper object for 'ndata'

diffstat: 13 files changed, 147 insertions(+), 275 deletions(-)
Attachment #624596 - Flags: review?(benjamin)
(Assignee)

Comment 1

5 years ago
Doing this should also allow us to remove nsIPluginStreamInfo easily.
(Assignee)

Comment 2

5 years ago
Created attachment 624768 [details] [diff] [review]
fix v1.1

nsNPAPIStreamWrapper doesn't need to be a COM object either.
Attachment #624596 - Attachment is obsolete: true
Attachment #624596 - Flags: review?(benjamin)
Attachment #624768 - Flags: review?(benjamin)

Updated

5 years ago
Attachment #624768 - Flags: review?(benjamin) → review+
(Assignee)

Comment 3

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=d7c643d19592
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/12020cb10ace
Status: NEW → ASSIGNED
(Assignee)

Comment 5

5 years ago
pushed to mozilla-central

https://hg.mozilla.org/mozilla-central/rev/12020cb10ace
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.