Closed Bug 755961 Opened 8 years ago Closed 8 years ago

plugin stream decomtamination: nsIPluginStreamListener

Categories

(Core :: Plug-ins, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch fix v1.0 (obsolete) — Splinter Review
nsIPluginStreamListener is unnecessary and complicates our stream handling. We can simplify things by removing it. The trickiest part is that we use QI to figure out what type of stream data we put in NPStream's 'ndata' field. With my patch we always use the same type of stream wrapper object for 'ndata'

diffstat: 13 files changed, 147 insertions(+), 275 deletions(-)
Attachment #624596 - Flags: review?(benjamin)
Doing this should also allow us to remove nsIPluginStreamInfo easily.
Attached patch fix v1.1Splinter Review
nsNPAPIStreamWrapper doesn't need to be a COM object either.
Attachment #624596 - Attachment is obsolete: true
Attachment #624596 - Flags: review?(benjamin)
Attachment #624768 - Flags: review?(benjamin)
Attachment #624768 - Flags: review?(benjamin) → review+
pushed to mozilla-central

https://hg.mozilla.org/mozilla-central/rev/12020cb10ace
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.