756010 - [VC8] "gfx/2d/ImageScalingSSE2.cpp(112) : error C3861: '_mm_castsi128_ps': identifier not found"

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Makoto Kato [:m_kato]]

This is bustage issue on VC8 compiler.  VC8 doesn't seem to support _mm_castsi128_ps.  So we should turn off SSE2 code when compiling ImageScalingSSE2.cpp.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Philip Chee]

SeaMonkey Windows builds are burning with:
e:/builds/slave/comm-cen-trunk-w32/build/mozilla/gfx/2d/ImageScalingSSE2.cpp(112) : error C3861: '_mm_castsi128_ps': identifier not found

e:/builds/slave/comm-cen-trunk-w32/build/mozilla/gfx/2d/ImageScalingSSE2.cpp(112) : error C3861: '_mm_castsi128_ps': identifier not found

e:/builds/slave/comm-cen-trunk-w32/build/mozilla/gfx/2d/ImageScalingSSE2.cpp(113) : error C3861: '_mm_castps_si128': identifier not found

e:/builds/slave/comm-cen-trunk-w32/build/mozilla/gfx/2d/ImageScalingSSE2.cpp(113) : error C3861: '_mm_castsi128_ps': identifier not found

e:/builds/slave/comm-cen-trunk-w32/build/mozilla/gfx/2d/ImageScalingSSE2.cpp(113) : error C3861: '_mm_castsi128_ps': identifier not found

e:/builds/slave/comm-cen-trunk-w32/build/mozilla/gfx/2d/ImageScalingSSE2.cpp(140) : error C3861: '_mm_castps_si128': identifier not found

e:/builds/slave/comm-cen-trunk-w32/build/mozilla/gfx/2d/ImageScalingSSE2.cpp(140) : error C3861: '_mm_castsi128_ps': identifier not found

e:/builds/slave/comm-cen-trunk-w32/build/mozilla/gfx/2d/ImageScalingSSE2.cpp(140) : error C3861: '_mm_castsi128_ps': identifier not found

e:/builds/slave/comm-cen-trunk-w32/build/mozilla/gfx/2d/ImageScalingSSE2.cpp(141) : error C3861: '_mm_castps_si128': identifier not found

e:/builds/slave/comm-cen-trunk-w32/build/mozilla/gfx/2d/ImageScalingSSE2.cpp(141) : error C3861: '_mm_castsi128_ps': identifier not found

e:/builds/slave/comm-cen-trunk-w32/build/mozilla/gfx/2d/ImageScalingSSE2.cpp(141) : error C3861: '_mm_castsi128_ps': identifier not found

e:/builds/slave/comm-cen-trunk-w32/build/mozilla/gfx/2d/ImageScalingSSE2.cpp(157) : error C3861: '_mm_castps_si128': identifier not found

We are planning to (try to) migrate to MSVC10 by this weekend.

Comment 3

[Serge Gautherie (:sgautherie)]

Ftr,

http://msdn.microsoft.com/en-us/library/bb514029(v=vs.100).aspx
{
_mm_castsi128_ps

Header file <emmintrin.h>
}

Comment 4

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/mozilla-central/rev/e34babb30393

Comment 5

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey&maxdate=1337313822&hours=24&legend=0&norules=1

V.Fixed