The default bug view has changed. See this FAQ.

make-makefile test failure if the source path contains perl regexp metacharacters

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Chris Coulson, Assigned: Chris Coulson)

Tracking

Trunk
mozilla15
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 624803 [details] [diff] [review]
Fix make-makefile test failure when the source path contains perl regexp metacharacters

We get this test failure when running make check in Ubuntu:

/usr/bin/perl /build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/runtest /build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/make-makefile.tpl
/build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/make-makefile.tpl .. ok
All tests successful.
Files=1, Tests=4,  1 wallclock secs ( 0.04 usr  0.00 sys +  0.33 cusr  0.08 csys =  0.45 CPU)
Result: PASS
/usr/bin/perl /build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/runtest /build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/makemakefile.tpm
# Test 6 got: "0" (/build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/makemakefile.tpm at line 123)
#   Expected: "1" (Invalid topdir path)
#  /build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/makemakefile.tpm line 123 is:     ok($FindBin::RealBin =~ m%$path/% ? 1 : 0, 1, 'Invalid topdir path');
/build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/makemakefile.tpm .. 
Failed 1/36 subtests 

Test Summary Report
-------------------
/build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/makemakefile.tpm (Wstat: 0 Tests: 36 Failed: 1)
  Failed test:  6
Files=1, Tests=36,  0 wallclock secs ( 0.06 usr  0.00 sys +  0.08 cusr  0.01 csys =  0.15 CPU)
Result: FAIL
Failed 1/1 test programs. 1/36 subtests failed.
make[3]: *** [.ts/makemakefile.tpm] Error 255
make[3]: Leaving directory `/build/buildd/firefox-12.0+build1/build-tree/mozilla/obj-x86_64-linux-gnu/build/autoconf/test'
make[2]: *** [check] Error 2
make[2]: Leaving directory `/build/buildd/firefox-12.0+build1/build-tree/mozilla/obj-x86_64-linux-gnu/build'
make[1]: *** [check] Error 2

This is because the path contains a perl regexp metacharacter ('+'), and this is not correctly quoted in the test
(Assignee)

Updated

5 years ago
Attachment #624803 - Flags: review?(coop)

Updated

5 years ago
Attachment #624803 - Flags: review?(coop) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Attachment #624803 - Attachment is patch: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/527400dc53a8
Assignee: nobody → chrisccoulson
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/527400dc53a8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.