Last Comment Bug 756219 - two pieces of nsComputedDOMStyle code cleanup
: two pieces of nsComputedDOMStyle code cleanup
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: CSS Object Model (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-17 12:43 PDT by David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
Modified: 2012-05-18 18:31 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove unused functions from nsComputedDOMStyle. (, patch 1) (5.39 KB, patch)
2012-05-17 12:45 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
Details | Diff | Review
Don't use Moz prefix on internal function names in nsComputedDOMStyle for recommendation-track properties. (, patch 2) (11.86 KB, patch)
2012-05-17 12:45 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
Details | Diff | Review

Description David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-05-17 12:43:09 PDT
I noticed two patches in my tree that had been there a while.
Comment 1 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-05-17 12:45:36 PDT
Created attachment 624844 [details] [diff] [review]
Remove unused functions from nsComputedDOMStyle.  (, patch 1)
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-05-17 12:45:56 PDT
Created attachment 624845 [details] [diff] [review]
Don't use Moz prefix on internal function names in nsComputedDOMStyle for recommendation-track properties.  (, patch 2)
Comment 3 Boris Zbarsky [:bz] (Out June 25-July 6) 2012-05-17 21:04:55 PDT
Comment on attachment 624844 [details] [diff] [review]
Remove unused functions from nsComputedDOMStyle.  (, patch 1)

r=me
Comment 4 Boris Zbarsky [:bz] (Out June 25-July 6) 2012-05-17 21:05:46 PDT
Comment on attachment 624845 [details] [diff] [review]
Don't use Moz prefix on internal function names in nsComputedDOMStyle for recommendation-track properties.  (, patch 2)

r=me
Comment 5 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-05-18 05:54:31 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7a34e60aeec
https://hg.mozilla.org/integration/mozilla-inbound/rev/a726c2e6cde7

Note You need to log in before you can comment on or make changes to this bug.