TreeContext generates lots of warnings

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 624849 [details] [diff] [review]
Patch
(Assignee)

Updated

5 years ago
Assignee: general → dzbarsky
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Attachment #624849 - Attachment is patch: true
Attachment #624849 - Flags: review?(n.nethercote)
(Assignee)

Updated

5 years ago
Summary: TreeContextFlags generates lots of warnings → TreeContext generates lots of warnings
Comment on attachment 624849 [details] [diff] [review]
Patch

Review of attachment 624849 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing :)

Which compiler gave the warnings?  GCC 4.6 on Linux doesn't complain about this.
Attachment #624849 - Flags: review?(n.nethercote) → review+
I believe both clang and MSVC do class-struct mismatch warnings.
(Assignee)

Comment 3

5 years ago
This was with clang.
(Assignee)

Comment 4

5 years ago
Created attachment 624987 [details] [diff] [review]
Patch r=njn
Attachment #624849 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/be270d77d19d

Thanks, David.
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/be270d77d19d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.