Last Comment Bug 756227 - TreeContext generates lots of warnings
: TreeContext generates lots of warnings
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: David Zbarsky (:dzbarsky)
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-17 12:55 PDT by David Zbarsky (:dzbarsky)
Modified: 2012-05-18 13:30 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (822 bytes, patch)
2012-05-17 12:55 PDT, David Zbarsky (:dzbarsky)
n.nethercote: review+
Details | Diff | Splinter Review
Patch r=njn (879 bytes, patch)
2012-05-17 18:26 PDT, David Zbarsky (:dzbarsky)
no flags Details | Diff | Splinter Review

Description David Zbarsky (:dzbarsky) 2012-05-17 12:55:53 PDT
Created attachment 624849 [details] [diff] [review]
Patch
Comment 1 Nicholas Nethercote [:njn] 2012-05-17 16:05:56 PDT
Comment on attachment 624849 [details] [diff] [review]
Patch

Review of attachment 624849 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing :)

Which compiler gave the warnings?  GCC 4.6 on Linux doesn't complain about this.
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2012-05-17 16:32:11 PDT
I believe both clang and MSVC do class-struct mismatch warnings.
Comment 3 David Zbarsky (:dzbarsky) 2012-05-17 17:16:20 PDT
This was with clang.
Comment 4 David Zbarsky (:dzbarsky) 2012-05-17 18:26:01 PDT
Created attachment 624987 [details] [diff] [review]
Patch r=njn
Comment 5 Nicholas Nethercote [:njn] 2012-05-17 18:42:58 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/be270d77d19d

Thanks, David.
Comment 6 :Ms2ger (⌚ UTC+1/+2) 2012-05-18 13:30:20 PDT
https://hg.mozilla.org/mozilla-central/rev/be270d77d19d

Note You need to log in before you can comment on or make changes to this bug.