Closed
Bug 756251
Opened 12 years ago
Closed 12 years ago
Pass extendedAttributes to CGCallGenerator
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: peterv, Assigned: peterv)
Details
Attachments
(1 file)
15.43 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
I'd like to use extendedAttributes in CGCallGenerator. We already pass resultAlreadyAddRefed into it, but that's calculated from extendedAttributes so I replaced the resultAlreadyAddRefed argument with extendedAttributes and calculate resultAlreadyAddRefed from it in CGCallGenerator.
Attachment #624867 -
Flags: review?(bzbarsky)
Comment 1•12 years ago
|
||
Comment on attachment 624867 [details] [diff] [review] v1 r=me. I'd been kinda trying to keep PerSignatureCall not caring about whether it's a getter/setter/method, but I agree this ends up cleaner since we don't have to pass the extendedAttributes around.
Attachment #624867 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f071e6f4d3b0
Target Milestone: --- → mozilla15
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f071e6f4d3b0
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•