The default bug view has changed. See this FAQ.

Pass extendedAttributes to CGCallGenerator

RESOLVED FIXED in mozilla15

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 624867 [details] [diff] [review]
v1

I'd like to use extendedAttributes in CGCallGenerator. We already pass resultAlreadyAddRefed into it, but that's calculated from extendedAttributes so I replaced the resultAlreadyAddRefed argument with extendedAttributes and calculate resultAlreadyAddRefed from it in CGCallGenerator.
Attachment #624867 - Flags: review?(bzbarsky)
Comment on attachment 624867 [details] [diff] [review]
v1

r=me.  I'd been kinda trying to keep PerSignatureCall not caring about whether it's a getter/setter/method, but I agree this ends up cleaner since we don't have to pass the extendedAttributes around.
Attachment #624867 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f071e6f4d3b0
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/f071e6f4d3b0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.