Last Comment Bug 756257 - Replace xpc_qsDOMString with a conversion function in new DOM bindings
: Replace xpc_qsDOMString with a conversion function in new DOM bindings
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Peter Van der Beken [:peterv]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-17 14:06 PDT by Peter Van der Beken [:peterv]
Modified: 2012-05-23 05:19 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (3.06 KB, patch)
2012-05-17 14:06 PDT, Peter Van der Beken [:peterv]
bzbarsky: review+
Details | Diff | Splinter Review

Description Peter Van der Beken [:peterv] 2012-05-17 14:06:33 PDT
Created attachment 624889 [details] [diff] [review]
v1

Using a nsDependentString and a conversion function makes it easier to support strings in unions (and makes us less dependent on quickstub stuff ;-)). Not sure if ConvertJSValueToString should be inlined as I did.
Comment 1 Boris Zbarsky [:bz] 2012-05-17 22:53:36 PDT
Comment on attachment 624889 [details] [diff] [review]
v1

r=me if you make the commit comment better.
Comment 2 Peter Van der Beken [:peterv] 2012-05-22 14:32:56 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/98940ba9637f
Comment 3 Ed Morley [:emorley] 2012-05-23 05:19:24 PDT
https://hg.mozilla.org/mozilla-central/rev/98940ba9637f

Note You need to log in before you can comment on or make changes to this bug.