I just filed bug 756216. It didn't contain the CC list I initially specified.
The CC list I set while entering the bug was "firstname.lastname@example.org, email@example.com, :rs, firstname.lastname@example.org, email@example.com, ".
Upon clicking Submit, bugzilla informed me that ":rs" was ambiguous, and let me select the right user from a <select>.
I was a bit surprised to find that it added _only_ the dis-ambiguated user (rob strong) to the CC list, and silently dropped the other users I specified. (The others entries in my list above were ok, I pasted it again without :rs and they were added in the additional submission.)
I cannot reproduce upstream.
i can reproduce this on landfill (4.0, 4.2 and tip).
So the problem happens with full email addresses entered in the CC list when another incomplete email address triggers the "Confirm Match" page. All incomplete email addresses are correctly listed, though, so this only affects full email addresses. Nobody reported this problem before probably because the auto-completion feature makes this less a problem.
Bugzilla 3.6.9 is not affected, so we regressed this in 4.0. Considering this bug as dataloss, it's a blocker for 4.0.7.
Regression due to bug 634243.
Created attachment 625925 [details] [diff] [review]
as far as i can tell, the right thing to do here is to only exclude the hidden field if it's empty.
Comment on attachment 625925 [details] [diff] [review]
This change is in the right direction, but this is not enough. You also have to revert the first change from attachment 512478 [details] [diff] [review] else a partial login name which matches exactly one login name will be inserted twice, which triggers an error for single-select fields.
Steps to reproduce:
- Enter "LpSolit" (or any partial name which matches only one account) in the assignee field.
- Enter a login name which matches several accounts in the CC list.
- Click commit, and select one account for the CC list in the confirmation page.
=> you get an error that LpSolit@...,LpSolit@... doesn't exist.
Created attachment 627717 [details] [diff] [review]
thanks for the clear steps to reproduce LpSolit!
this should address that issue.
Comment on attachment 627717 [details] [diff] [review]
Committing to: bzr+ssh://firstname.lastname@example.org/bugzilla/4.0/
Committed revision 7709.
Committing to: bzr+ssh://email@example.com/bugzilla/4.2/
Committed revision 8090.
Committing to: bzr+ssh://firstname.lastname@example.org/bugzilla/trunk/
Committed revision 8246.