756317 - Webapp.domain_from_url does not respect port

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect, P2)

Description

[Christopher Van Wiemeersch [:cvan]]

Webapp.domain_from_url strips the port (https://github.com/mozilla/zamboni/blob/master/mkt/webapps/models.py#L164) and gives us only the hostname:

    In [1]: Webapp.domain_from_url('http://localhost')
    Out[1]: 'localhost'

    In [2]: Webapp.domain_from_url('http://localhost:9000')
    Out[2]: 'localhost'

This means if you have submitted an app to the Marketplace at https://cbc.ca/manifest.webapp then you will not be able to submit a manifest for https://cbc.ca:8080/manifest.webapp

Comment 1

[Wil Clouser [:clouserw]]

From email:

Origin is defined in the manifest spec as:

<protocol>://<name>:<port>

Therefore for the purposes of apps, domain.com:8080 should be a different app from domain.com; and https://domain.com should also be treated as a separate app from http://domain.com

Comment 2

[Rob Hudson [:robhudson]]

Sounds like keeping everything up to the and including the port might be optimal, like the following...

>>> Webapp.domain_from_url('http://localhost/path/to/manifest.webapp')
'http://localhost'
>>> Webapp.domain_from_url('https://localhost:8080/path/to/manifest.webapp')
'https://localhost:8080'

If we stored all that it would provide unique matches taking protocol, name, and port into account.

Comment 3

[Rob Hudson [:robhudson]]

https://github.com/robhudson/zamboni/commit/bb8824a