do-not-wrap in addbuiltin broken

RESOLVED FIXED

Status

NSS
Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: kaie, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
The patch for bug 744651 introduced a new bug.

The bug can be seen when running the addbuiltin tool,
the "do not wrap" feature no longer works,
and output like the following is produced:

# Trust for "StartCom Certification Authority (sha256)"
# Issuer: CN=StartCom Certification Authority,OU=Secure Digital Certificate S
    igning,O=StartCom Ltd.,C=IL

# Serial Number: 45 (0x2d)
# Subject: CN=StartCom Certification Authority,OU=Secure Digital Certificate 
    Signing,O=StartCom Ltd.,C=IL
...
# Fingerprint (MD5):
    3D:3B:18:9E:2C:64:5A:E8:D5:88:CE:0E:F9:37:C2:EC
# Fingerprint (SHA1):
    DA:FA:F7:FA:66:84:EC:06:8F:14:50:BD:C7:C2:81:A5:BC:A9:64:57


The problem has been caused by creating a second static variable wrapEnabled. Calling the function to configure the wrap/do-not-wrap only has effect in one of the source files.
(Reporter)

Updated

6 years ago
Depends on: 744651
No longer depends on: 728044
(Reporter)

Comment 1

6 years ago
Created attachment 624976 [details] [diff] [review]
Patch v1
Attachment #624976 - Flags: review?(emaldona)

Updated

6 years ago
Attachment #624976 - Flags: review?(emaldona) → review+
(Reporter)

Comment 2

6 years ago
Checking in secutil.c;
/cvsroot/mozilla/security/nss/cmd/lib/secutil.c,v  <--  secutil.c
new revision: 1.121; previous revision: 1.120
done
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.