756382 - --enable-xterm-updates with make -s spews blank lines into the console

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Simon Montagu :smontagu]

Attachment: Patch

This has annoyed me for ages, and I finally found a solution which works for me at least.

I'm not sure whether I need to go on using xterm.str or whether that was just a way to get the binary characters.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 625023 [details] [diff] [review]
Patch

Review of attachment 625023 [details] [diff] [review]:
-----------------------------------------------------------------

printf isn't really portable, but this is off-by-default anyway, so I'm not sure I care.

Comment 2

[(not currently active) Ted Mielczarek]

I think Neil is the only other person I've ever seen express interest in this.

Comment 3

[[e-mail]]

(In reply to Simon Montagu)
> I'm not sure whether I need to go on using xterm.str or whether that was
> just a way to get the binary characters.
The idea was that xterm.str did not end in a newline, the intention being that sed would honour that in its output, so you should hg remove it.

Comment 4

[Simon Montagu :smontagu]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7915a59a1691 (including the hg remove)

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7915a59a1691