Closed
Bug 756397
Opened 13 years ago
Closed 13 years ago
Enable FAIL_ON_WARNINGS in content/media
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
4.99 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #754643 +++
cc1plus: warnings being treated as errors
In file included from ../../../dist/include/VideoUtils.h:43:0,
from ../../../../content/media/ogg/nsOggCodecState.h:55,
from ../../../../content/media/ogg/nsOggCodecState.cpp:40:
../../../dist/include/mozilla/CheckedInt.h: In static member function 'static bool mozilla::detail::IsInRangeImpl<T, U, true, true>::run(U) [with T = long long int, U = int]':
../../../dist/include/mozilla/CheckedInt.h:317:36: instantiated from 'bool mozilla::detail::IsInRange(U) [with T = long long int, U = int]'
../../../dist/include/mozilla/CheckedInt.h:530:45: instantiated from 'mozilla::CheckedInt<T>::CheckedInt(U) [with U = int, T = long long int]'
../../../../content/media/ogg/nsOggCodecState.cpp:629:9: instantiated from here
../../../dist/include/mozilla/CheckedInt.h:280:59: error: comparison is always true due to limited range of data type
../../../dist/include/mozilla/CheckedInt.h:280:59: error: comparison is always true due to limited range of data type
Assignee | ||
Comment 1•13 years ago
|
||
Updated•13 years ago
|
Attachment #639696 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Comment 3•12 years ago
|
||
MFBT isn't the right component for this -- should've been "Video/Audio", presumably.
Component: MFBT → Video/Audio
Depends on: FAIL_ON_WARNINGS
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #3)
> MFBT isn't the right component for this -- should've been "Video/Audio",
> presumably.
FWIW, it was in MFBT because the only warnings were caused by CheckedInt.h at the time.
You need to log in
before you can comment on or make changes to this bug.
Description
•