The default bug view has changed. See this FAQ.

Enable FAIL_ON_WARNINGS in content/media

RESOLVED FIXED in mozilla17

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

Trunk
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #754643 +++

cc1plus: warnings being treated as errors
In file included from ../../../dist/include/VideoUtils.h:43:0,
                 from ../../../../content/media/ogg/nsOggCodecState.h:55,
                 from ../../../../content/media/ogg/nsOggCodecState.cpp:40:
../../../dist/include/mozilla/CheckedInt.h: In static member function 'static bool mozilla::detail::IsInRangeImpl<T, U, true, true>::run(U) [with T = long long int, U = int]':
../../../dist/include/mozilla/CheckedInt.h:317:36:   instantiated from 'bool mozilla::detail::IsInRange(U) [with T = long long int, U = int]'
../../../dist/include/mozilla/CheckedInt.h:530:45:   instantiated from 'mozilla::CheckedInt<T>::CheckedInt(U) [with U = int, T = long long int]'
../../../../content/media/ogg/nsOggCodecState.cpp:629:9:   instantiated from here
../../../dist/include/mozilla/CheckedInt.h:280:59: error: comparison is always true due to limited range of data type
../../../dist/include/mozilla/CheckedInt.h:280:59: error: comparison is always true due to limited range of data type
(Assignee)

Updated

5 years ago
Depends on: 768570
(Assignee)

Comment 1

5 years ago
Created attachment 639696 [details] [diff] [review]
Patch v1
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #639696 - Flags: review?(cpearce)
Attachment #639696 - Flags: review?(cpearce) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f060a6883f1f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
MFBT isn't the right component for this -- should've been "Video/Audio", presumably.
Component: MFBT → Video/Audio
Depends on: 557566
(Assignee)

Comment 4

4 years ago
(In reply to Daniel Holbert [:dholbert] from comment #3)
> MFBT isn't the right component for this -- should've been "Video/Audio",
> presumably.

FWIW, it was in MFBT because the only warnings were caused by CheckedInt.h at the time.
You need to log in before you can comment on or make changes to this bug.