756405 - non-scaling-stroke-02.svg fails on Android

Status: RESOLVED FIXED

Description

[Robert Longson]

Comment 1

[Robert Longson]

Created attachment 625466 [details] [diff] [review]
patch

It's a permanent failure in only one of the reftests. Just 38 pixels don't match, the test and ref are visually indistinguishable. I assume this is an artifact from the fact that the reftest is scaled as the drawing is otherwise exactly the same as non-scaling-stroke-01. Because of this I think having this one test fuzzy match on Android is the simplest answer.

Comment 2

[Robert Longson]

Comment on attachment 625466 [details] [diff] [review]
patch

>diff --git a/layout/reftests/svg/reftest.list b/layout/reftests/svg/reftest.list
>--- a/layout/reftests/svg/reftest.list
>+++ b/layout/reftests/svg/reftest.list
>@@ -169,19 +169,18 @@ fails == inline-in-xul-basic-01.xul pass
> == marker-viewBox-01.svg marker-viewBox-01-ref.svg
> == mask-basic-01.svg pass.svg
> == mask-basic-02.svg mask-basic-02-ref.svg
> == mask-extref-dataURI-01.svg pass.svg
> == mask-containing-masked-content-01.svg pass.svg
> == mask-transformed-01.svg mask-transformed-01-ref.svg
> == nested-viewBox-01.svg pass.svg
> == nesting-invalid-01.svg nesting-invalid-01-ref.svg
>-# Bug 756405
>-random-if(Android) == non-scaling-stroke-01.svg non-scaling-stroke-01-ref.svg 
>-random-if(Android) == non-scaling-stroke-02.svg non-scaling-stroke-02-ref.svg 
>+== non-scaling-stroke-01.svg non-scaling-stroke-01-ref.svg 
>+fuzzy-if(Android,9,38) == non-scaling-stroke-02.svg non-scaling-stroke-02-ref.svg 
> == objectBoundingBox-and-clipPath.svg pass.svg
> # Bug 588684
> random-if(gtk2Widget) == objectBoundingBox-and-fePointLight-01.svg objectBoundingBox-and-fePointLight-01-ref.svg
> random-if(gtk2Widget) == objectBoundingBox-and-fePointLight-02.svg objectBoundingBox-and-fePointLight-02-ref.svg
> == objectBoundingBox-and-mask.svg pass.svg
> == objectBoundingBox-and-mask-02.svg pass.svg
> == objectBoundingBox-and-pattern-01a.svg objectBoundingBox-and-pattern-01-ref.svg
> == objectBoundingBox-and-pattern-01b.svg objectBoundingBox-and-pattern-01-ref.svg

Comment 3

[Robert Longson]

https://hg.mozilla.org/integration/mozilla-inbound/rev/443c0c79e54f

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/443c0c79e54f