756445 - redefinition of test method in test_AUS.py

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

I was running Balrog through pyflakes this afternoon and it said this:
auslib/test/test_AUS.py:123: redefinition of function 'testSpecialQueryParamForced' from line 107

And indeed, we have two methods named the same in that class:
https://github.com/mozilla/balrog/blob/master/auslib/test/test_AUS.py#L107
https://github.com/mozilla/balrog/blob/master/auslib/test/test_AUS.py#L123

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Fix tests

Looks like a copy-and-paste-o for the forcing test for a non-bouncer download site. 

The other change here is to resolve this message while running tests:
.../balrog/auslib/web/views/forms.py:31: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6
  self.process_errors.append(e.message)
I picked up usage in wtforms/fields.py where it's also catching ValueError.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

... and all the tests PASS afterwards, but that's otherwise untested.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 625865 [details] [diff] [review]
Fix tests

https://github.com/mozilla/balrog/commit/978296577ee06e4b18891a9c7c7321d20026ff8e

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Green Jenkins run:
 https://jenkins.mozilla.org/job/Balrog/89/