Note: There are a few cases of duplicates in user autocompletion which are being worked on.

[compare-locales] merge content wrong with more than one error per file

RESOLVED FIXED

Status

Mozilla Localizations
Infrastructure
--
major
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 625083 [details] [diff] [review]
sort skips by start offset

The entries for skips in ContentComparer.merge were ordered per key, and not by file location. That means, the chunks to be removed for errornous values weren't sequenced, and thus the resulting file would be, say, non-optimal.

The fix is easy, just sort the thing by start offset.

I verified this by running over a few merge outputs which have errors on fx_central.
(Assignee)

Comment 1

5 years ago
Comment on attachment 625083 [details] [diff] [review]
sort skips by start offset

Gandalf said he'd take a look at this, requesting review.
Attachment #625083 - Flags: review?(gandalf)
Comment on attachment 625083 [details] [diff] [review]
sort skips by start offset

Review of attachment 625083 [details] [diff] [review]:
-----------------------------------------------------------------

looks and works good :)
Attachment #625083 - Flags: review?(gandalf) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/l10n/compare-locales/rev/a36840ad87a1, FIXED.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.