Last Comment Bug 756576 - nsDOMAttributeMap::Init should be removed
: nsDOMAttributeMap::Init should be removed
Status: RESOLVED FIXED
[mentor=bsmedberg][lang=c++]
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: Jignesh Kakadiya [:jhk]
:
Mentors:
Depends on: 734847
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-18 13:09 PDT by Benjamin Smedberg [:bsmedberg]
Modified: 2012-05-23 06:44 PDT (History)
5 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch(v1) (1.55 KB, patch)
2012-05-18 14:08 PDT, Jignesh Kakadiya [:jhk]
no flags Details | Diff | Splinter Review
Patch(v1) (2.17 KB, patch)
2012-05-18 14:11 PDT, Jignesh Kakadiya [:jhk]
benjamin: review+
Details | Diff | Splinter Review

Description Benjamin Smedberg [:bsmedberg] 2012-05-18 13:09:15 PDT
Now that hashtable init is infallible (bug 734847), nsDOMAttributeMap::Init is also infallible and should be folded into the constructor/removed.
Comment 1 Josh Matthews [:jdm] (away until 9/3) 2012-05-18 13:48:27 PDT
http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsDOMAttributeMap.cpp
Comment 2 Jignesh Kakadiya [:jhk] 2012-05-18 14:08:59 PDT
Created attachment 625261 [details] [diff] [review]
Patch(v1)
Comment 3 Jignesh Kakadiya [:jhk] 2012-05-18 14:11:34 PDT
Created attachment 625262 [details] [diff] [review]
Patch(v1)

Forget to refresh. Please review this one.
Comment 4 Benjamin Smedberg [:bsmedberg] 2012-05-22 11:09:37 PDT
Comment on attachment 625262 [details] [diff] [review]
Patch(v1)

Great. Do you know how to get this landed or do you need help with that?
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-05-22 17:40:15 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/640557f458be

I had to un-bitrot nsDOMAttributeMap.cpp a bit. Please make sure that I didn't mess it up.
Comment 6 Ed Morley [:emorley] 2012-05-23 04:52:06 PDT
https://hg.mozilla.org/mozilla-central/rev/640557f458be
Comment 7 :Ms2ger (⌚ UTC+1/+2) 2012-05-23 06:44:04 PDT
(In reply to Ryan VanderMeulen from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/640557f458be
> 
> I had to un-bitrot nsDOMAttributeMap.cpp a bit. Please make sure that I
> didn't mess it up.

Confirmed.

Note You need to log in before you can comment on or make changes to this bug.