nsDOMAttributeMap::Init should be removed

RESOLVED FIXED in mozilla15

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bsmedberg, Assigned: jhk)

Tracking

unspecified
mozilla15
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=bsmedberg][lang=c++])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Now that hashtable init is infallible (bug 734847), nsDOMAttributeMap::Init is also infallible and should be folded into the constructor/removed.

Comment 1

5 years ago
http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsDOMAttributeMap.cpp
(Assignee)

Comment 2

5 years ago
Created attachment 625261 [details] [diff] [review]
Patch(v1)
Attachment #625261 - Flags: review?(benjamin)
(Assignee)

Comment 3

5 years ago
Created attachment 625262 [details] [diff] [review]
Patch(v1)

Forget to refresh. Please review this one.
(Assignee)

Updated

5 years ago
Attachment #625262 - Flags: review?(benjamin)
(Assignee)

Updated

5 years ago
Attachment #625261 - Flags: review?(benjamin)
(Reporter)

Comment 4

5 years ago
Comment on attachment 625262 [details] [diff] [review]
Patch(v1)

Great. Do you know how to get this landed or do you need help with that?
Attachment #625262 - Flags: review?(benjamin) → review+

Updated

5 years ago
Assignee: nobody → jigneshhk1992
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Attachment #625261 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/640557f458be

I had to un-bitrot nsDOMAttributeMap.cpp a bit. Please make sure that I didn't mess it up.
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/640557f458be
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(In reply to Ryan VanderMeulen from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/640557f458be
> 
> I had to un-bitrot nsDOMAttributeMap.cpp a bit. Please make sure that I
> didn't mess it up.

Confirmed.
You need to log in before you can comment on or make changes to this bug.