Closed Bug 756576 Opened 13 years ago Closed 13 years ago

nsDOMAttributeMap::Init should be removed

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: benjamin, Assigned: jhk)

References

Details

(Whiteboard: [mentor=bsmedberg][lang=c++])

Attachments

(1 file, 1 obsolete file)

Patch(v1)
2.17 KB, patch
benjamin
: review+
Details | Diff | Splinter Review
Now that hashtable init is infallible (bug 734847), nsDOMAttributeMap::Init is also infallible and should be folded into the constructor/removed.
Attached patch Patch(v1) (obsolete) — — Splinter Review
Attachment #625261 - Flags: review?(benjamin)
Attached patch Patch(v1) — — Splinter Review
Forget to refresh. Please review this one.
Attachment #625262 - Flags: review?(benjamin)
Attachment #625261 - Flags: review?(benjamin)
Comment on attachment 625262 [details] [diff] [review] Patch(v1) Great. Do you know how to get this landed or do you need help with that?
Attachment #625262 - Flags: review?(benjamin) → review+
Assignee: nobody → jigneshhk1992
Keywords: checkin-needed
Attachment #625261 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/640557f458be I had to un-bitrot nsDOMAttributeMap.cpp a bit. Please make sure that I didn't mess it up.
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/640557f458be
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
(In reply to Ryan VanderMeulen from comment #5) > https://hg.mozilla.org/integration/mozilla-inbound/rev/640557f458be > > I had to un-bitrot nsDOMAttributeMap.cpp a bit. Please make sure that I > didn't mess it up. Confirmed.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: