Last Comment Bug 756576 - nsDOMAttributeMap::Init should be removed
: nsDOMAttributeMap::Init should be removed
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla15
Assigned To: Jignesh Kakadiya [:jhk]
: Andrew Overholt [:overholt]
Depends on: 734847
  Show dependency treegraph
Reported: 2012-05-18 13:09 PDT by Benjamin Smedberg [:bsmedberg]
Modified: 2012-05-23 06:44 PDT (History)
5 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch(v1) (1.55 KB, patch)
2012-05-18 14:08 PDT, Jignesh Kakadiya [:jhk]
no flags Details | Diff | Splinter Review
Patch(v1) (2.17 KB, patch)
2012-05-18 14:11 PDT, Jignesh Kakadiya [:jhk]
benjamin: review+
Details | Diff | Splinter Review

Description User image Benjamin Smedberg [:bsmedberg] 2012-05-18 13:09:15 PDT
Now that hashtable init is infallible (bug 734847), nsDOMAttributeMap::Init is also infallible and should be folded into the constructor/removed.
Comment 2 User image Jignesh Kakadiya [:jhk] 2012-05-18 14:08:59 PDT
Created attachment 625261 [details] [diff] [review]
Comment 3 User image Jignesh Kakadiya [:jhk] 2012-05-18 14:11:34 PDT
Created attachment 625262 [details] [diff] [review]

Forget to refresh. Please review this one.
Comment 4 User image Benjamin Smedberg [:bsmedberg] 2012-05-22 11:09:37 PDT
Comment on attachment 625262 [details] [diff] [review]

Great. Do you know how to get this landed or do you need help with that?
Comment 5 User image Ryan VanderMeulen [:RyanVM] 2012-05-22 17:40:15 PDT

I had to un-bitrot nsDOMAttributeMap.cpp a bit. Please make sure that I didn't mess it up.
Comment 6 User image Ed Morley [:emorley] 2012-05-23 04:52:06 PDT
Comment 7 User image :Ms2ger (⌚ UTC+1/+2) 2012-05-23 06:44:04 PDT
(In reply to Ryan VanderMeulen from comment #5)
> I had to un-bitrot nsDOMAttributeMap.cpp a bit. Please make sure that I
> didn't mess it up.


Note You need to log in before you can comment on or make changes to this bug.