Closed
Bug 756682
Opened 13 years ago
Closed 13 years ago
Move BloomFilter test at xpcom/tests/TestBloomFilter.cpp into mfbt/tests
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
People
(Reporter: Waldo, Unassigned)
Details
mfbt tests should live in mfbt.
|
Reporter | |
Comment 1•13 years ago
|
||
This will require a little trickery concerning the TestHarness.h dependency. The only existing test right now just writes to std::cerr manually and doesn't use methods that ensure output is printed in a way tinderbox can understand. Perhaps we should convert it to use such methods, or something. I dunno.
|
|
Reporter | |
Comment 2•13 years ago
|
||
Apparently I forgot about this bug when I made this move:
http://hg.mozilla.org/mozilla-central/rev/4e3e7e1496af
As for comment 1's trickery, I just used MOZ_ASSERT and lived with that. Which is not actually a very good thing, as bug 807607 just noted, but it made forward progress, so was perhaps good enough in the short run. Longer term, we need a real story for C++ unit tests. (Actual unit tests in this case, even, not what Mozilla calls unit tests, which are just tests writ large.)
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•