Closed Bug 756746 Opened 10 years ago Closed 10 years ago

Quote paths in linker scripts

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: mwu, Assigned: mwu)

Details

Attachments

(1 file)

Add double quotes around paths in linker scripts
1.26 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
Exotic paths kill linking if there are no double quotes.
Attachment #625376 - Flags: review?(mh+mozilla)
Comment on attachment 625376 [details] [diff] [review]
Add double quotes around paths in linker scripts

Review of attachment 625376 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/expandlibs_exec.py
@@ +125,4 @@
>          if not len(objs): return
>          fd, tmp = tempfile.mkstemp(suffix=".list",dir=os.curdir)
>          if conf.EXPAND_LIBS_LIST_STYLE == "linkerscript":
> +            content = ["INPUT(\"%s\")\n" % obj for obj in objs]

I'd prefer to avoid the backslashes by switching the string to single quotes.
Attachment #625376 - Flags: review?(mh+mozilla) → review+
Switched to single quotes, fixed the test.

https://hg.mozilla.org/integration/mozilla-inbound/rev/da3c5b7c2c7e
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/da3c5b7c2c7e
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.