Last Comment Bug 756746 - Quote paths in linker scripts
: Quote paths in linker scripts
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: Michael Wu [:mwu]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-19 01:37 PDT by Michael Wu [:mwu]
Modified: 2012-05-19 18:38 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Attachments
Add double quotes around paths in linker scripts (1.26 KB, patch)
2012-05-19 01:37 PDT, Michael Wu [:mwu] 		mh+mozilla: review+
Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Michael Wu [:mwu] 2012-05-19 01:37:52 PDT 
Created attachment 625376 [details] [diff] [review]
Add double quotes around paths in linker scripts

Exotic paths kill linking if there are no double quotes.
Comment 1 Mike Hommey [:glandium] 2012-05-19 01:40:37 PDT 
Comment on attachment 625376 [details] [diff] [review]
Add double quotes around paths in linker scripts

Review of attachment 625376 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/expandlibs_exec.py
@@ +125,4 @@
>          if not len(objs): return
>          fd, tmp = tempfile.mkstemp(suffix=".list",dir=os.curdir)
>          if conf.EXPAND_LIBS_LIST_STYLE == "linkerscript":
> +            content = ["INPUT(\"%s\")\n" % obj for obj in objs]

I'd prefer to avoid the backslashes by switching the string to single quotes.
Comment 2 Michael Wu [:mwu] 2012-05-19 14:05:39 PDT 
Switched to single quotes, fixed the test.

https://hg.mozilla.org/integration/mozilla-inbound/rev/da3c5b7c2c7e
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-05-19 18:38:15 PDT 
https://hg.mozilla.org/mozilla-central/rev/da3c5b7c2c7e
Note You need to log in before you can comment on or make changes to this bug.