756746 - Quote paths in linker scripts

Status: RESOLVED FIXED

Description

[Michael Wu [:mwu]]

Created attachment 625376 [details] [diff] [review]
Add double quotes around paths in linker scripts

Exotic paths kill linking if there are no double quotes.

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 625376 [details] [diff] [review]
Add double quotes around paths in linker scripts

Review of attachment 625376 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/expandlibs_exec.py
@@ +125,4 @@
>          if not len(objs): return
>          fd, tmp = tempfile.mkstemp(suffix=".list",dir=os.curdir)
>          if conf.EXPAND_LIBS_LIST_STYLE == "linkerscript":
> +            content = ["INPUT(\"%s\")\n" % obj for obj in objs]

I'd prefer to avoid the backslashes by switching the string to single quotes.

Comment 2

[Michael Wu [:mwu]]

Switched to single quotes, fixed the test.

https://hg.mozilla.org/integration/mozilla-inbound/rev/da3c5b7c2c7e

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/da3c5b7c2c7e