Closed Bug 756746 Opened 13 years ago Closed 13 years ago

Quote paths in linker scripts

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla15

People

(Reporter: mwu, Assigned: mwu)

Details

Attachments

(1 file)

Exotic paths kill linking if there are no double quotes.
Attachment #625376 - Flags: review?(mh+mozilla)
Comment on attachment 625376 [details] [diff] [review] Add double quotes around paths in linker scripts Review of attachment 625376 [details] [diff] [review]: ----------------------------------------------------------------- ::: config/expandlibs_exec.py @@ +125,4 @@ > if not len(objs): return > fd, tmp = tempfile.mkstemp(suffix=".list",dir=os.curdir) > if conf.EXPAND_LIBS_LIST_STYLE == "linkerscript": > + content = ["INPUT(\"%s\")\n" % obj for obj in objs] I'd prefer to avoid the backslashes by switching the string to single quotes.
Attachment #625376 - Flags: review?(mh+mozilla) → review+
Target Milestone: --- → mozilla15
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: