Closed
Bug 756746
Opened 8 years ago
Closed 8 years ago
Quote paths in linker scripts
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: mwu, Assigned: mwu)
Details
Attachments
(1 file)
|
1.26 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Exotic paths kill linking if there are no double quotes.
Attachment #625376 -
Flags: review?(mh+mozilla)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 625376 [details] [diff] [review] Add double quotes around paths in linker scripts Review of attachment 625376 [details] [diff] [review]: ----------------------------------------------------------------- ::: config/expandlibs_exec.py @@ +125,4 @@ > if not len(objs): return > fd, tmp = tempfile.mkstemp(suffix=".list",dir=os.curdir) > if conf.EXPAND_LIBS_LIST_STYLE == "linkerscript": > + content = ["INPUT(\"%s\")\n" % obj for obj in objs] I'd prefer to avoid the backslashes by switching the string to single quotes.
Attachment #625376 -
Flags: review?(mh+mozilla) → review+
|
Assignee | |
Comment 2•8 years ago
|
||
Switched to single quotes, fixed the test. https://hg.mozilla.org/integration/mozilla-inbound/rev/da3c5b7c2c7e
Target Milestone: --- → mozilla15
|
||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/da3c5b7c2c7e
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•