Closed
Bug 756757
Opened 13 years ago
Closed 13 years ago
Use nsINode in nsHTMLEditor::MergeCells
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
5.24 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #625390 -
Flags: review?(ehsan)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 625390 [details] [diff] [review]
Patch v1
Review of attachment 625390 [details] [diff] [review]:
-----------------------------------------------------------------
::: editor/libeditor/html/nsTableEditor.cpp
@@ +2380,5 @@
> }
>
> // Move the contents
> + while (cellToMerge->HasChildren()) {
> + nsIDOMNode* cellChild = cellToMerge->GetLastChild()->AsDOMNode();
Hmm, this is a bit scary, since you're grabbing cellChild as a raw pointer, calling DeleteNode which _could_ destroy the object, and then you're passing it to InsertNode. Please use an nsCOMPtr here.
Attachment #625390 -
Flags: review?(ehsan) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•