756759 - Remove gnomestripe's non-native fallback styling for toolbarbuttons

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

The fallback styling shouldn't really be needed on Linux and is annoying to override because of the inflationary use of !important in the [checked="true"] rules.

While I'm at it, I'm also getting rid of Lighten.png.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch v2

Oops, I removed too much. The text colors are still needed.

Comment 2

[[e-mail]]

Comment on attachment 625395 [details] [diff] [review]
patch v2

>+  background-color: rgba(255,255,255,0.5);
rgba(255, 255, 255, 0.5); unless you or gavin can point to some style guideline that says that you must cram all the values together.

Comment 3

[Dão Gottwald [:dao]]

It doesn't matter here, but in places where you combine multiple color values, spaces within these values reduce the overall readability.

e.g.
-moz-linear-gradient(bottom, rgba(10%, 10%, 10%, .4) 1px, transparent 1px)
vs.
-moz-linear-gradient(bottom, rgba(10%,10%,10%,.4) 1px, transparent 1px)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 625395 [details] [diff] [review]
patch v2

I don't really feel strongly either way!

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/56b75c384bbe

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/56b75c384bbe

Comment 7

[Philip Chee]

> It doesn't matter here, but in places where you combine multiple color values,
> spaces within these values reduce the overall readability.
Actually spaces *increase* readability. Us old fogeys tend not to have 20/20 vision unlike you pesky kids.

Comment 8

[Dão Gottwald [:dao]]

(In reply to Philip Chee from comment #7)
> > It doesn't matter here, but in places where you combine multiple color values,
> > spaces within these values reduce the overall readability.
> Actually spaces *increase* readability. Us old fogeys tend not to have 20/20
> vision unlike you pesky kids.

This has nothing to do with vision. It's easier to skim the whole thing when all the spaces clearly delimit the values.