756813 - crash in mozilla::layers::ImageContainer::GetCurrentSize

Status: RESOLVED FIXED

Description

[Andreas Gal :gal]

This bug was filed from the Socorro interface and is 
report bp-e36766b9-17d2-4593-89b6-ecaa12120519 .
============================================================= 

We have to do state.mImageRenderer.GetContainer() early in nsDisplayBackground::TryOptimizeToImageLayer and if it returns null, don't optimize into a layer.

This crash only happens when gpu image scaling is enabled, which is OFF by default so product and trunk aren't affected.

Comment 1

[David Zbarsky (:dzbarsky)]

Created attachment 625440 [details] [diff] [review]
Patch

Comment 2

[Andreas Gal :gal]

Comment on attachment 625440 [details] [diff] [review]
Patch

I would pull this into a local and then use that further down, but up to you.

Comment 3

[Andreas Gal :gal]

e/contenteditable.css ../../../layout/style/designmode.css ../../../layout/style/TopLevelImageDocument.css ../../../layout/style/TopLevelVideoDocument.css ../../dist/bin/res
/Users/gal/workspace/mozilla-central/layout/base/nsDisplayList.cpp: In member function ‘bool nsDisplayBackground::TryOptimizeToImageLayer(nsDisplayListBuilder*)’:
/Users/gal/workspace/mozilla-central/layout/base/nsDisplayList.cpp:1168: error: no match for ‘operator!’ in ‘!state.nsBackgroundLayerState::mImageRenderer. nsImageRenderer::GetContainer()’
/Users/gal/workspace/mozilla-central/layout/base/nsDisplayList.cpp:1168: note: candidates are: operator!(bool) <built-in>

Comment 4

[Andreas Gal :gal]

Created attachment 625481 [details] [diff] [review]
patch

Comment 5

[Andreas Gal :gal]

This page often crashes for me without the patch:

http://www.mobileasiaexpo.com/

It has a large scaled background images and it loads pretty slowly, causing us to paint before the image is ready, resulting in a crash.

Works with my version of the patch. Lets land it.

Comment 6

[David Zbarsky (:dzbarsky)]

Yeah, I made the same change locally.  I don't have L3 access so I can't actually land anything.

Comment 7

[David Zbarsky (:dzbarsky)]

Created attachment 625509 [details] [diff] [review]
Patch

Comment 8

[Andreas Gal :gal]

I am not of much use these days, but comment 6 I can fix!

Comment 9

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1aaec6842f6f

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1aaec6842f6f