The default bug view has changed. See this FAQ.

crash in mozilla::layers::ImageContainer::GetCurrentSize

RESOLVED FIXED in mozilla15

Status

()

Core
Graphics: Layers
--
major
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gal, Assigned: dzbarsky)

Tracking

({crash})

Trunk
mozilla15
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
This bug was filed from the Socorro interface and is 
report bp-e36766b9-17d2-4593-89b6-ecaa12120519 .
============================================================= 

We have to do state.mImageRenderer.GetContainer() early in nsDisplayBackground::TryOptimizeToImageLayer and if it returns null, don't optimize into a layer.

This crash only happens when gpu image scaling is enabled, which is OFF by default so product and trunk aren't affected.
(Reporter)

Updated

5 years ago
Assignee: nobody → dzbarsky
(Assignee)

Comment 1

5 years ago
Created attachment 625440 [details] [diff] [review]
Patch
Attachment #625440 - Flags: review?(gal)
(Reporter)

Comment 2

5 years ago
Comment on attachment 625440 [details] [diff] [review]
Patch

I would pull this into a local and then use that further down, but up to you.
Attachment #625440 - Flags: review?(gal) → review+
(Reporter)

Comment 3

5 years ago
e/contenteditable.css ../../../layout/style/designmode.css ../../../layout/style/TopLevelImageDocument.css ../../../layout/style/TopLevelVideoDocument.css ../../dist/bin/res
/Users/gal/workspace/mozilla-central/layout/base/nsDisplayList.cpp: In member function ‘bool nsDisplayBackground::TryOptimizeToImageLayer(nsDisplayListBuilder*)’:
/Users/gal/workspace/mozilla-central/layout/base/nsDisplayList.cpp:1168: error: no match for ‘operator!’ in ‘!state.nsBackgroundLayerState::mImageRenderer. nsImageRenderer::GetContainer()’
/Users/gal/workspace/mozilla-central/layout/base/nsDisplayList.cpp:1168: note: candidates are: operator!(bool) <built-in>
(Reporter)

Comment 4

5 years ago
Created attachment 625481 [details] [diff] [review]
patch
(Reporter)

Comment 5

5 years ago
This page often crashes for me without the patch:

http://www.mobileasiaexpo.com/

It has a large scaled background images and it loads pretty slowly, causing us to paint before the image is ready, resulting in a crash.

Works with my version of the patch. Lets land it.
(Assignee)

Comment 6

5 years ago
Yeah, I made the same change locally.  I don't have L3 access so I can't actually land anything.
(Assignee)

Comment 7

5 years ago
Created attachment 625509 [details] [diff] [review]
Patch
Attachment #625440 - Attachment is obsolete: true
Attachment #625481 - Attachment is obsolete: true
(Reporter)

Updated

5 years ago
Attachment #625509 - Flags: review+
(Reporter)

Comment 8

5 years ago
I am not of much use these days, but comment 6 I can fix!
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1aaec6842f6f
https://hg.mozilla.org/mozilla-central/rev/1aaec6842f6f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.