Closed
Bug 756813
Opened 13 years ago
Closed 13 years ago
crash in mozilla::layers::ImageContainer::GetCurrentSize
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: gal, Assigned: dzbarsky)
Details
(Keywords: crash)
Crash Data
Attachments
(1 file, 2 obsolete files)
1.90 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is
report bp-e36766b9-17d2-4593-89b6-ecaa12120519 .
=============================================================
We have to do state.mImageRenderer.GetContainer() early in nsDisplayBackground::TryOptimizeToImageLayer and if it returns null, don't optimize into a layer.
This crash only happens when gpu image scaling is enabled, which is OFF by default so product and trunk aren't affected.
Reporter | ||
Updated•13 years ago
|
Assignee: nobody → dzbarsky
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #625440 -
Flags: review?(gal)
Reporter | ||
Comment 2•13 years ago
|
||
Comment on attachment 625440 [details] [diff] [review]
Patch
I would pull this into a local and then use that further down, but up to you.
Attachment #625440 -
Flags: review?(gal) → review+
Reporter | ||
Comment 3•13 years ago
|
||
e/contenteditable.css ../../../layout/style/designmode.css ../../../layout/style/TopLevelImageDocument.css ../../../layout/style/TopLevelVideoDocument.css ../../dist/bin/res
/Users/gal/workspace/mozilla-central/layout/base/nsDisplayList.cpp: In member function ‘bool nsDisplayBackground::TryOptimizeToImageLayer(nsDisplayListBuilder*)’:
/Users/gal/workspace/mozilla-central/layout/base/nsDisplayList.cpp:1168: error: no match for ‘operator!’ in ‘!state.nsBackgroundLayerState::mImageRenderer. nsImageRenderer::GetContainer()’
/Users/gal/workspace/mozilla-central/layout/base/nsDisplayList.cpp:1168: note: candidates are: operator!(bool) <built-in>
Reporter | ||
Comment 4•13 years ago
|
||
Reporter | ||
Comment 5•13 years ago
|
||
This page often crashes for me without the patch:
http://www.mobileasiaexpo.com/
It has a large scaled background images and it loads pretty slowly, causing us to paint before the image is ready, resulting in a crash.
Works with my version of the patch. Lets land it.
Assignee | ||
Comment 6•13 years ago
|
||
Yeah, I made the same change locally. I don't have L3 access so I can't actually land anything.
Assignee | ||
Comment 7•13 years ago
|
||
Attachment #625440 -
Attachment is obsolete: true
Attachment #625481 -
Attachment is obsolete: true
Reporter | ||
Updated•13 years ago
|
Attachment #625509 -
Flags: review+
Assignee | ||
Comment 9•13 years ago
|
||
Comment 10•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•