756823 - rm Root, s/RootedVar/Root/g

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brian Hackett [Laid off!]]

Root<T> isn't used for much, and things would me more concise if it was removed and RootedVar<T> was renamed to Root<T>.  This would also make rooted variables slightly more efficient by killing a store during initialization.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: patch (5fc7462dd394)

Massive patch, but is basically just doing what's in the bug name.  Everything interesting is in the header files --- changes to gc/Root.h, and rewriting inner autorooter classes which previously depended on Root<T>.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 625444 [details] [diff] [review]
patch (5fc7462dd394)

Review of attachment 625444 [details] [diff] [review]:
-----------------------------------------------------------------

Personally I would prefer the name RootedX to RootX, but whatever. This is a step forward.

Comment 3

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/779d3807d806

This just does the rm Root part, I had to work out some mysterious non-reproducible tbpl failures and it seems better to split up.  I can do Rooted<T> for the second part.

Comment 4

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb914b623fa7

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fb914b623fa7

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

And

https://hg.mozilla.org/mozilla-central/rev/779d3807d806