Last Comment Bug 756823 - rm Root, s/RootedVar/Root/g
: rm Root, s/RootedVar/Root/g
Status: RESOLVED FIXED
[js:t]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Other Branch
: x86 Mac OS X
: -- normal (vote)
: mozilla15
Assigned To: Brian Hackett (:bhackett)
:
Mentors:
Depends on:
Blocks: 753609
  Show dependency treegraph
 
Reported: 2012-05-19 15:13 PDT by Brian Hackett (:bhackett)
Modified: 2012-05-25 08:32 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (5fc7462dd394) (612.01 KB, patch)
2012-05-19 15:17 PDT, Brian Hackett (:bhackett)
wmccloskey: review+
Details | Diff | Splinter Review

Description Brian Hackett (:bhackett) 2012-05-19 15:13:40 PDT
Root<T> isn't used for much, and things would me more concise if it was removed and RootedVar<T> was renamed to Root<T>.  This would also make rooted variables slightly more efficient by killing a store during initialization.
Comment 1 Brian Hackett (:bhackett) 2012-05-19 15:17:16 PDT
Created attachment 625444 [details] [diff] [review]
patch (5fc7462dd394)

Massive patch, but is basically just doing what's in the bug name.  Everything interesting is in the header files --- changes to gc/Root.h, and rewriting inner autorooter classes which previously depended on Root<T>.
Comment 2 Bill McCloskey (:billm) 2012-05-21 18:08:12 PDT
Comment on attachment 625444 [details] [diff] [review]
patch (5fc7462dd394)

Review of attachment 625444 [details] [diff] [review]:
-----------------------------------------------------------------

Personally I would prefer the name RootedX to RootX, but whatever. This is a step forward.
Comment 3 Brian Hackett (:bhackett) 2012-05-24 08:55:42 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/779d3807d806

This just does the rm Root part, I had to work out some mysterious non-reproducible tbpl failures and it seems better to split up.  I can do Rooted<T> for the second part.
Comment 4 Brian Hackett (:bhackett) 2012-05-24 16:09:29 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb914b623fa7
Comment 5 Ed Morley [:emorley] 2012-05-25 08:24:37 PDT
https://hg.mozilla.org/mozilla-central/rev/fb914b623fa7

Note You need to log in before you can comment on or make changes to this bug.