rm Root, s/RootedVar/Root/g

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

Other Branch
mozilla15
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Root<T> isn't used for much, and things would me more concise if it was removed and RootedVar<T> was renamed to Root<T>.  This would also make rooted variables slightly more efficient by killing a store during initialization.
(Assignee)

Comment 1

5 years ago
Created attachment 625444 [details] [diff] [review]
patch (5fc7462dd394)

Massive patch, but is basically just doing what's in the bug name.  Everything interesting is in the header files --- changes to gc/Root.h, and rewriting inner autorooter classes which previously depended on Root<T>.
Assignee: general → bhackett1024
Attachment #625444 - Flags: review?(wmccloskey)
Comment on attachment 625444 [details] [diff] [review]
patch (5fc7462dd394)

Review of attachment 625444 [details] [diff] [review]:
-----------------------------------------------------------------

Personally I would prefer the name RootedX to RootX, but whatever. This is a step forward.
Attachment #625444 - Flags: review?(wmccloskey) → review+
Whiteboard: [js:t]
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/779d3807d806

This just does the rm Root part, I had to work out some mysterious non-reproducible tbpl failures and it seems better to split up.  I can do Rooted<T> for the second part.
Whiteboard: [js:t] → [js:t][leave open when merging]
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb914b623fa7
Whiteboard: [js:t][leave open when merging] → [js:t]

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/fb914b623fa7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
And

https://hg.mozilla.org/mozilla-central/rev/779d3807d806
You need to log in before you can comment on or make changes to this bug.