The default bug view has changed. See this FAQ.

Rollup of a bunch of small GCLI changes

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Console
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

unspecified
Firefox 15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Includes:
- Split gcliblank out so we can have different markup for the output panel
  and tooltip panel
- Export the dimensions (start/end) of the current parameter to tooltip
- Set the default eagerness to SOMETIMES
- Fix the leftover issued from Bug 720641 comment 97
- Fix focus issues which caused the toolbar not to get focus properly when
  opened
- Use html:iframe not xul:iframe to workaround XUL issue
- Remove resize code which was a different attempt to workaround this issue
- Rename _anchor to _toolbar, since the use was confusing
- Change the anchor to be the input textbox
- Resize the width of the output panel as well as the height
- Don't use arrow panels
- Make the tooltip panel move horizontally with the current parameter
Created attachment 625649 [details] [diff] [review]
Upload 1
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #625649 - Flags: review?(dcamp)
https://tbpl.mozilla.org/?tree=Try&rev=5b32c8cb3ad5
Blocks: 756890

Comment 3

5 years ago
Comment on attachment 625649 [details] [diff] [review]
Upload 1

Review of attachment 625649 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/DeveloperToolbar.jsm
@@ +552,2 @@
>  
> +  this._panel.ownerDocument.defaultView.setTimeout(function() {

Can you include a comment explaining what you're working around with this setTimeout?
Attachment #625649 - Flags: review?(dcamp) → review+
Created attachment 625695 [details] [diff] [review]
Upload 2

> "Can you include a comment explaining what you're working around with this setTimeout?"

Done.
Also this rebases for the MPL change.
Attachment #625649 - Attachment is obsolete: true
https://tbpl.mozilla.org/?tree=Try&rev=b94c25fdbc97
Blocks: 745773
Created attachment 625782 [details] [diff] [review]
Upload 3

Discovered an intermittent leak.
Fixed.
Attachment #625695 - Attachment is obsolete: true
https://tbpl.mozilla.org/?tree=Try&rev=822d87d80351
https://tbpl.mozilla.org/?tree=Fx-Team&rev=a84e147b4d22
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a84e147b4d22
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.