Closed Bug 756888 Opened 10 years ago Closed 10 years ago

Rollup of a bunch of small GCLI changes

Categories

(DevTools :: Console, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 15

People

(Reporter: jwalker, Assigned: jwalker)

References

Details

Attachments

(1 file, 2 obsolete files)

Includes:
- Split gcliblank out so we can have different markup for the output panel
  and tooltip panel
- Export the dimensions (start/end) of the current parameter to tooltip
- Set the default eagerness to SOMETIMES
- Fix the leftover issued from Bug 720641 comment 97
- Fix focus issues which caused the toolbar not to get focus properly when
  opened
- Use html:iframe not xul:iframe to workaround XUL issue
- Remove resize code which was a different attempt to workaround this issue
- Rename _anchor to _toolbar, since the use was confusing
- Change the anchor to be the input textbox
- Resize the width of the output panel as well as the height
- Don't use arrow panels
- Make the tooltip panel move horizontally with the current parameter
Attached patch Upload 1 (obsolete) — Splinter Review
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #625649 - Flags: review?(dcamp)
Blocks: 756890
Comment on attachment 625649 [details] [diff] [review]
Upload 1

Review of attachment 625649 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/DeveloperToolbar.jsm
@@ +552,2 @@
>  
> +  this._panel.ownerDocument.defaultView.setTimeout(function() {

Can you include a comment explaining what you're working around with this setTimeout?
Attachment #625649 - Flags: review?(dcamp) → review+
Attached patch Upload 2 (obsolete) — Splinter Review
> "Can you include a comment explaining what you're working around with this setTimeout?"

Done.
Also this rebases for the MPL change.
Attachment #625649 - Attachment is obsolete: true
Blocks: 745773
Attached patch Upload 3Splinter Review
Discovered an intermittent leak.
Fixed.
Attachment #625695 - Attachment is obsolete: true
https://tbpl.mozilla.org/?tree=Fx-Team&rev=a84e147b4d22
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a84e147b4d22
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.