756888 - Rollup of a bunch of small GCLI changes

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Joe Walker [:jwalker]]

Includes:
- Split gcliblank out so we can have different markup for the output panel
  and tooltip panel
- Export the dimensions (start/end) of the current parameter to tooltip
- Set the default eagerness to SOMETIMES
- Fix the leftover issued from Bug 720641 comment 97
- Fix focus issues which caused the toolbar not to get focus properly when
  opened
- Use html:iframe not xul:iframe to workaround XUL issue
- Remove resize code which was a different attempt to workaround this issue
- Rename _anchor to _toolbar, since the use was confusing
- Change the anchor to be the input textbox
- Resize the width of the output panel as well as the height
- Don't use arrow panels
- Make the tooltip panel move horizontally with the current parameter

Comment 1

[Joe Walker [:jwalker]]

Attachment: Upload 1

Comment 2

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=5b32c8cb3ad5

Comment 3

[Dave Camp (:dcamp)]

Comment on attachment 625649 [details] [diff] [review]
Upload 1

Review of attachment 625649 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/DeveloperToolbar.jsm
@@ +552,2 @@
>  
> +  this._panel.ownerDocument.defaultView.setTimeout(function() {

Can you include a comment explaining what you're working around with this setTimeout?

Comment 4

[Joe Walker [:jwalker]]

Attachment: Upload 2

> "Can you include a comment explaining what you're working around with this setTimeout?"

Done.
Also this rebases for the MPL change.

Comment 5

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=b94c25fdbc97

Comment 6

[Joe Walker [:jwalker]]

Attachment: Upload 3

Discovered an intermittent leak.
Fixed.

Comment 7

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=822d87d80351

Comment 8

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=a84e147b4d22

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/a84e147b4d22