Last Comment Bug 756993 - Reset hide fullscreen warning timeouts when a new domain enters fullscreen
: Reset hide fullscreen warning timeouts when a new domain enters fullscreen
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 15
Assigned To: Chris Pearce (:cpearce)
:
Mentors:
Depends on: 753546
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-21 02:44 PDT by Chris Pearce (:cpearce)
Modified: 2012-05-24 09:24 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch: Reset fullscreen approval UI each time fullscren is entered. (2.01 KB, patch)
2012-05-21 02:48 PDT, Chris Pearce (:cpearce)
dao+bmo: review+
Details | Diff | Splinter Review

Description Chris Pearce (:cpearce) 2012-05-21 02:44:15 PDT
If you enter fullscreen in domain A which is approved for fullscreen, and then quickly enter domain B which isn't, the "A is now fullscreen" warning will have a timer to auto-hide the warning which isn't reset when we reset the strings to reflect B now being fullscreen. In other words, we'll auto hide the B's approval UI, even though B was not approved for fullscreen.

We should not; explicit approval should be required.
Comment 1 Chris Pearce (:cpearce) 2012-05-21 02:48:39 PDT
Created attachment 625586 [details] [diff] [review]
Patch: Reset fullscreen approval UI each time fullscren is entered.

Reset the auto-hide and fade out transition attributes when reconfiguring the fullscreen warning/approval UI when a domain enters fullscreen. This means the timeout from an approved domain won't cause the approval UI to hide on a unapproved domain.
Comment 3 Ed Morley [:emorley] 2012-05-24 09:24:10 PDT
https://hg.mozilla.org/mozilla-central/rev/f5a06123348c

Note You need to log in before you can comment on or make changes to this bug.