Reset hide fullscreen warning timeouts when a new domain enters fullscreen

RESOLVED FIXED in Firefox 15

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

Trunk
Firefox 15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
If you enter fullscreen in domain A which is approved for fullscreen, and then quickly enter domain B which isn't, the "A is now fullscreen" warning will have a timer to auto-hide the warning which isn't reset when we reset the strings to reflect B now being fullscreen. In other words, we'll auto hide the B's approval UI, even though B was not approved for fullscreen.

We should not; explicit approval should be required.
(Assignee)

Comment 1

5 years ago
Created attachment 625586 [details] [diff] [review]
Patch: Reset fullscreen approval UI each time fullscren is entered.

Reset the auto-hide and fade out transition attributes when reconfiguring the fullscreen warning/approval UI when a domain enters fullscreen. This means the timeout from an approved domain won't cause the approval UI to hide on a unapproved domain.
Attachment #625586 - Flags: review?(dao)

Updated

5 years ago
Attachment #625586 - Flags: review?(dao) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5a06123348c
Target Milestone: --- → Firefox 15

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f5a06123348c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.