756995 - Linux and Windows Opt unit tests not running on comm-esr10 branch

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mark Banner (:standard8)]

The opt unit tests aren't running on the comm-esr10 branch. I took a look through the configs but couldn't see anything obvious.

From what I can tell:

- sendchange gets sent from opt builds
- there are opt unit test builders specifically for comm-esr10
- no pending builds get queued or listed
- The config for comm-esr10 looks the same as Firefox. I couldn't see any specific overrides.

coop, can you take a look? We're going to need this for the next esr release, i.e. we'll want this set up before John gets back.

Comment 1

[Mark Banner (:standard8)]

It appears I was slightly wrong. We do get opt unit tests on Mac, but not on Linux or Windows.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

I believe this should fix it - once I realised Mac was the only one working, that then leads to something different about Linux & Windows. I re-checked the sendchange that the opt builders were generating and it had "pgo" in the branch name.

As we're not doing pgo on any of our branches, a bit of tracing lead to pgo_strategy being the issue.

There's still some things about enable_pgo = True, but they are on branches that are currently working. So I'll just file a follow-up bug on those and removal can be tested on staging before we change those.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 625971 [details] [diff] [review]
The fix

http://hg.mozilla.org/build/buildbot-configs/rev/72baa99b9ada

Comment 4

[Mark Banner (:standard8)]

This landed on production yesterday and opt tests are being trigged just fine now.