Marionette should gracefully handle navigation attempts that throw exceptions

RESOLVED WONTFIX

Status

Testing
Marionette
RESOLVED WONTFIX
6 years ago
4 years ago

People

(Reporter: jgriffin, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][lang=js][mentor=mdas])

(Reporter)

Description

6 years ago
If you call marionette.navigate() with an invalid url, Marionette doesn't catch the exception that the browser throws, and thus hangs.  We should gracefully handle this.

Example:
  marionette.navigate('file://./test/page.html')

Result:
  stdout shows this:  "JavaScript error: , line 0: uncaught exception: An error occurred throwing an exception".  Marionette doesn't catch this exception and so hangs. 

We can fix this by wrapping

  curWindow.location = msg.json.value

in a try/catch block, and returning an appropriate error message.
Depends on: 756577
(Reporter)

Updated

5 years ago
Blocks: 846091
Whiteboard: [good first bug][lang=js][mentor=mdas]
Seems to work now
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.