Closed Bug 757177 Opened 8 years ago Closed 8 years ago

4 unused variable warnings in new file SVGFragmentIdentifier.cpp

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 512525 added the new file SVGFragmentIdentifier.cpp with some unused variables in it:
{
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp: In static member function 'static bool mozilla::SVGFragmentIdentifier::ProcessSVGViewSpec(const nsAString_internal&, nsSVGSVGElement*)':
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:151:27: warning: unused variable 'oldViewBoxPtr' [-Wunused-variable]
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:159:33: warning: unused variable 'oldPARPtr' [-Wunused-variable]
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:167:19: warning: unused variable 'oldZoomAndPanPtr' [-Wunused-variable]
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp: At global scope:
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:14:25: warning: 'sZoomAndPanMap' defined but not used [-Wunused-variable]
}
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Attached patch fixSplinter Review
Looks like all of these variables were just left over from an older patch-version, and they now have versions of themselves that live elsewhere (which are actually used).

The only "sZoomAndPanMap" that we use lives on nsSVGSVGElement (so the local one can go away), and the "oldXXX" variables now live in their various "SaveOldXXX" functions (so they can go away too).
Attachment #625737 - Flags: review?(longsonr)
Attachment #625737 - Flags: review?(longsonr) → review+
https://hg.mozilla.org/mozilla-central/rev/18f739e8ac9d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Duplicate of this bug: 759435
You need to log in before you can comment on or make changes to this bug.