The default bug view has changed. See this FAQ.

4 unused variable warnings in new file SVGFragmentIdentifier.cpp

RESOLVED FIXED in mozilla15

Status

()

Core
SVG
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Bug 512525 added the new file SVGFragmentIdentifier.cpp with some unused variables in it:
{
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp: In static member function 'static bool mozilla::SVGFragmentIdentifier::ProcessSVGViewSpec(const nsAString_internal&, nsSVGSVGElement*)':
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:151:27: warning: unused variable 'oldViewBoxPtr' [-Wunused-variable]
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:159:33: warning: unused variable 'oldPARPtr' [-Wunused-variable]
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:167:19: warning: unused variable 'oldZoomAndPanPtr' [-Wunused-variable]
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp: At global scope:
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:14:25: warning: 'sZoomAndPanMap' defined but not used [-Wunused-variable]
}
(Assignee)

Updated

5 years ago
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
OS: Linux → All
Hardware: x86_64 → All
(Assignee)

Comment 1

5 years ago
Created attachment 625737 [details] [diff] [review]
fix

Looks like all of these variables were just left over from an older patch-version, and they now have versions of themselves that live elsewhere (which are actually used).

The only "sZoomAndPanMap" that we use lives on nsSVGSVGElement (so the local one can go away), and the "oldXXX" variables now live in their various "SaveOldXXX" functions (so they can go away too).
Attachment #625737 - Flags: review?(longsonr)

Updated

5 years ago
Attachment #625737 - Flags: review?(longsonr) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/18f739e8ac9d
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/18f739e8ac9d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Duplicate of this bug: 759435
You need to log in before you can comment on or make changes to this bug.