757177 - 4 unused variable warnings in new file SVGFragmentIdentifier.cpp

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Daniel Holbert [:dholbert]]

Bug 512525 added the new file SVGFragmentIdentifier.cpp with some unused variables in it:
{
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp: In static member function 'static bool mozilla::SVGFragmentIdentifier::ProcessSVGViewSpec(const nsAString_internal&, nsSVGSVGElement*)':
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:151:27: warning: unused variable 'oldViewBoxPtr' [-Wunused-variable]
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:159:33: warning: unused variable 'oldPARPtr' [-Wunused-variable]
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:167:19: warning: unused variable 'oldZoomAndPanPtr' [-Wunused-variable]
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp: At global scope:
../../../../../mozilla/content/svg/content/src/SVGFragmentIdentifier.cpp:14:25: warning: 'sZoomAndPanMap' defined but not used [-Wunused-variable]
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Looks like all of these variables were just left over from an older patch-version, and they now have versions of themselves that live elsewhere (which are actually used).

The only "sZoomAndPanMap" that we use lives on nsSVGSVGElement (so the local one can go away), and the "oldXXX" variables now live in their various "SaveOldXXX" functions (so they can go away too).

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/18f739e8ac9d

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/18f739e8ac9d