Handle positions are not saved.

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Debugger
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: espadrine, Assigned: vporof)

Tracking

15 Branch
Firefox 15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
The two vertical separators in the debugger pane
can be used to resize the left and right pane.
However, the position of those separators are not
saved after the debugger is closed.

The position should be saved.
Priority: -- → P2
(Assignee)

Updated

5 years ago
Assignee: nobody → vporof
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 628333 [details] [diff] [review]
v1
Attachment #628333 - Flags: review?(rcampbell)
(Assignee)

Comment 2

5 years ago
Created attachment 628334 [details] [diff] [review]
v1.1

Added test.
Attachment #628333 - Flags: review?(rcampbell)
Comment on attachment 628334 [details] [diff] [review]
v1.1

So this only saves pane state (size) on destroy? Is that often enough?

A little thinking, says it should be... Maybe more thinking required.

-      <vbox id="stack" flex="1">
-        <vbox id="stackframes" class="dbg-default" flex="1"/>
-      </vbox>
-      <splitter id="stack-script-splitter"
-                class="devtools-side-splitter"/>
-      <vbox id="editor" class="dbg-default" flex="1"/>
-      <splitter id="script-properties-splitter"
-                class="devtools-side-splitter"/>
-      <vbox id="properties" flex="1">
-        <vbox id="variables" class="dbg-default" flex="1"/>
-      </vbox>
+      <vbox id="stackframes"/>
+      <splitter id="stack-script-splitter" class="devtools-side-splitter"/>
+      <vbox id="editor" flex="1"/>
+      <splitter id="script-properties-splitter" class="devtools-side-splitter"/>
+      <vbox id="variables"/>
     </hbox>

not *strictly* necessary, but it's acceptable cleanup.

OK!
Attachment #628334 - Flags: review+
(Assignee)

Comment 4

5 years ago
(In reply to Rob Campbell [:rc] (:robcee) from comment #3)
> Comment on attachment 628334 [details] [diff] [review]
> v1.1
> 
> So this only saves pane state (size) on destroy? Is that often enough?
> 
> A little thinking, says it should be... Maybe more thinking required.
> 

I can (over)think of a single case: opening a script debugger and a remote debugger at the same time.

> 
> not *strictly* necessary, but it's acceptable cleanup.
>

Quite necessary. The additional flexes didn't let me resize the bastard.

> OK!

^_^
(Assignee)

Comment 5

5 years ago
Created attachment 628635 [details] [diff] [review]
v1.2

Fixed an orange.
Attachment #628333 - Attachment is obsolete: true
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/fd4ff7253be8
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/fd4ff7253be8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.