75730 - Fix for Qt version check in configure.in

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[John Griggs]

Some people have reported errors resolving exit() in the code to check for the
version of the Qt library.  This call seems to be redundant (the code that
follows exit(0) is return(0)), so I have removed the call.  I have only provided
a patch for configure.in, since configure is generated.

Comment 1

[John Griggs]

Attachment: Patch to remove exit() from code to check Qt version

Comment 2

[Daniel (Leaf) Nunes]

i don't see harm, r=leaf... did they say why this was causing problems?

Comment 3

[John C. Griggs]

From a thread about this on netscape.public.mozilla.qt:

it looks like the problem is not qt ..... from my config.log:

onfigure:6641: checking Qt - version >= 2.2.0
configure:6655: c++ -c  -pipe -I/usr/lib/qt-2.2.0//include -DQT_GENUINE_STR
-I/usr/X11R6/include conftest.C 1>&5
configure: In function `int main ()':
configure:6650: `exit' undeclared (first use this function)
configure:6650: (Each undeclared identifier is reported only once for
each function it appears in.)
configure: failed program was:
#line 6643 "configure"
#include "confdefs.h"
#include <qglobal.h>
int main() {

        #if (QT_VERSION < 220)
            #error  "QT_VERSION too old"
        #endif
        exit(0);

; return 0; }

Comment 4

[cls]

Patch has been checked in.  Marking fixed.

Looks like the compiler was barfing because exit() wasn't declared.  Adding
#include <stdlib.h> might have fixed the problem as well.

Comment 5

[Jon Granrose]

verified.