Closed
Bug 757336
Opened 12 years ago
Closed 12 years ago
Cleanup probes handling in CompileScript()
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
(Whiteboard: [js:t])
Attachments
(1 file)
|
13.60 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
This patch:
- Uses a new one-shot class, ProbesManager, to provide RAII for
handling probes in CompileScript. This allows removal of the goto
statements, and some variable declarations to be moved lower.
- BytecodeEmitter is passed |lineno| instead of tokenStream.getLineno(),
because they're the same thing and |lineno| is simpler.
- TreeContext::init() doesn't need the JSContext* param, so I removed it.
- compileScript{Begin,End}() also had unnecessary params, which I removed.
Attachment #625904 -
Flags: review?(sphink)
|
||
Updated•12 years ago
|
Attachment #625904 -
Flags: review?(sphink) → review+
|
||
Updated•12 years ago
|
Whiteboard: [js:t]
|
Assignee | |
Comment 1•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4af1ce11dbed
Target Milestone: --- → mozilla15
|
||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4af1ce11dbed
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•