Cleanup probes handling in CompileScript()

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 625904 [details] [diff] [review]
patch

This patch:

- Uses a new one-shot class, ProbesManager, to provide RAII for 
  handling probes in CompileScript.  This allows removal of the goto
  statements, and some variable declarations to be moved lower.
  
- BytecodeEmitter is passed |lineno| instead of tokenStream.getLineno(), 
  because they're the same thing and |lineno| is simpler.
  
- TreeContext::init() doesn't need the JSContext* param, so I removed it.

- compileScript{Begin,End}() also had unnecessary params, which I removed.
Attachment #625904 - Flags: review?(sphink)
Attachment #625904 - Flags: review?(sphink) → review+
Whiteboard: [js:t]
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4af1ce11dbed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/4af1ce11dbed
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.