75734 - configure fails if "directory" does not exist

Status: VERIFIED FIXED

(Directory :: LDAP XPCOM SDK, defect)

Description

[robbe]

(May I say that calling a directory "directory" is kinda clumsy, even if it
makes some sense with LDAP <g>.)

Anyways, if one wants to builds in a directory seperate from the source (e.g.
"mkdir _build_; ../configure"), "directory" is not yet present. An "mkdir
directory/c-sdk" that is attempted at the end of the configure script therfore
has to fail.

  if test ! -d "directory"; then
    mkdir "directory"    
  fi

should be inserted before that.

If not already the case, one or two Unix tinderboxen should be modified to build
in a seperate build-dir, so these errors are catched quickly.

Comment 1

[cls]

Um, most of the tinderboxes (ports anyway) build in a separate obj-tree as do I
and I've never hit this error.  Looking at configure.in, directory/xpcom would
have been created as a result of the toplevel configure run so it would already
exist when running directory/c-sdk/ldap's configure.   What source tree are you
using?

Comment 2

[robbe]

This turned out to be a fallout from trying to build psm2 (following
instructions in bug 75018). Forcing my tree back to trunk level killed all
problems. user error, marking INVALID.

Sorry for the bother

Comment 3

[cls]

verified.

Comment 4

[robbe]

Found out that building PSM2 in a separate object dir can cause this. I.e.

mkdir build_psm2
cd build_psm2
../configure --enable-modules=psm2

will give this error. Reopening and moving to Directory.

Comment 5

[robbe]

Reassigning to dmose as per message <9dhove$[e-mail]>.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

cls', is robbe's proposed fix the right one?  It would work, but is part of the
problem really the fact that the ldap stuff isn't part of what client.mk
considers a "module"?  Any opinions about the best thing to do here?

Comment 7

[cls]

Attachment: Don't run ldap configure unless necessary & create directory

Comment 8

[cls]

Attachment: Fix if test to use output of grep -c rather than shell return value

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

cls: is BUILD_MODULES intended to take precedence over an explicitly specified
--enable-ldap?

Comment 10

[cls]

Well, --enable-ldap is currently a no-op, right?  The only way BUILD_MODULES
gets set to anything other than "all" is via --enable-modules.  If we're
specifying a standalone module to build and we want to build ldap as well, then
we should specify it in the standalone modules list.

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

ok, r=dmose

Comment 12

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 13

[cls]

Patch has been checked in.

Comment 14

[Jon Granrose]

verified.