75739 - InnerFrame paints BG incorrectly

Status: RESOLVED WORKSFORME

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[rods (gone)]

Outerframe makes two calls that causes the InnerFrame to be painted twice. The 
InnerFrame's paint paints the rect at mRect coords.

The first time it paints this is the correct location, the second time it paints 
via OuterFrames call to nsHTMLContainerFrame::Paint it paint incorrectly, 
meaning it really ought to be painting at 0,0,mRect.width,mRect.height.

See the code below, but it is confusing as to why it does the paint of the first 
child and then call the paint for the container. My feeling is that the first 
call should be removed in OuterFrame paint and the InnerFrame should paint at 
0,0,mRect.width,mRect.height

(NOTE: I have filed bug 75737 on this same issue (but for printing only) and 
will use that bug to put in a temporary fix until you can figure this out and 
get it checked in. Please remove the temporary fix when you check this fix in.

NS_IMETHODIMP
nsHTMLFrameOuterFrame::Paint(nsIPresContext* aPresContext,
                             nsIRenderingContext& aRenderingContext,
                             const nsRect& aDirtyRect,
                             nsFramePaintLayer aWhichLayer)
{
  //printf("outer paint %X (%d,%d,%d,%d) \n", this, aDirtyRect.x, aDirtyRect.y, 
aDirtyRect.width, aDirtyRect.height);
  nsIFrame* firstChild = mFrames.FirstChild();
  if (nsnull != firstChild) {
    firstChild->Paint(aPresContext, aRenderingContext, aDirtyRect,
                      aWhichLayer);
  }
  if (IsInline()) {
    return nsHTMLContainerFrame::Paint(aPresContext, aRenderingContext,
                                       aDirtyRect, aWhichLayer);
  } else {
    return NS_OK;
  }
}

Comment 1

[karnaze (gone)]

Reassigning to pollman and changing component from layout to html frames.

Comment 2

[Blake Ross]

Doesn't look like this is getting fixed before the freeze tonight.
Pushing out a milestone.  Please correct if I'm mistaken.

Comment 3

[Kevin McCluskey (gone)]

Bulk reassignin HTML FRAME/IFRAME bugs to Eric.

Comment 4

[Kevin McCluskey (gone)]

Bulk re-assigning all of Eric's HTMLFrame bugs to John.

Comment 5

[Vedran Miletic]

retargeting

Comment 6

[Boris Zbarsky [:bzbarsky]]

roc, I assume your innerframe removal makes this bug all better?

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, although I'm not completely sure without a testcase.

Comment 8

[Boris Zbarsky [:bzbarsky]]

No testcase, the code involved is gone... marking worksforme.