Closed
Bug 757392
Opened 13 years ago
Closed 13 years ago
crash in nsIDocument::GetRootElement mainly with JAWS 11
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: MarcoZ, Assigned: surkov)
Details
(Keywords: crash)
Crash Data
Attachments
(1 file, 1 obsolete file)
934 bytes,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is
report bp-ed0a3edc-42e6-457a-b7f8-523c82120519 .
=============================================================
Reported to me by a community member.
Comment 1•13 years ago
|
||
It's a low volume crash that only affects JAWS 11 users at least in 14.0a2 and 15.0a1.
More reports at:
https://crash-stats.mozilla.com/report/list?signature=nsIDocument%3A%3AGetRootElement%28%29
Summary: crash in nsIDocument::GetRootElement → crash in nsIDocument::GetRootElement mainly with JAWS 11
Assignee | ||
Comment 2•13 years ago
|
||
no better ideas
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #629235 -
Flags: review?(trev.saunders)
Comment 3•13 years ago
|
||
Comment on attachment 629235 [details] [diff] [review]
patch
>diff --git a/accessible/src/generic/DocAccessible.cpp b/accessible/src/generic/DocAccessible.cpp
>--- a/accessible/src/generic/DocAccessible.cpp
>+++ b/accessible/src/generic/DocAccessible.cpp
>@@ -631,16 +631,19 @@ DocAccessible::Shutdown()
> if (!mPresShell) // already shutdown
> return;
>
> #ifdef DEBUG
> if (logging::IsEnabled(logging::eDocDestroy))
> logging::DocDestroy("document shutdown", mDocument, this);
> #endif
>
>+ // Mark early since it seems ATs get lucky to call into us during shutdown.
>+ mFlags |= eIsDefunct;
>+
> if (mNotificationController) {
> mNotificationController->Shutdown();
> mNotificationController = nsnull;
> }
>
> RemoveEventListeners();
>
> // Mark the document as shutdown before AT is notified about the document
want to update this comment? or perhaps mark it as defunct here, to restore behavior from before making IsDefunct() inline?
Assignee | ||
Comment 4•13 years ago
|
||
it's reasonable assumption since bug 737724 (inlinging IsDefunct()) is landed on 14 where the crash appeared.
Assignee | ||
Comment 5•13 years ago
|
||
Attachment #629235 -
Attachment is obsolete: true
Attachment #629235 -
Flags: review?(trev.saunders)
Attachment #629249 -
Flags: review?(trev.saunders)
Updated•13 years ago
|
Attachment #629249 -
Flags: review?(trev.saunders) → review+
Assignee | ||
Comment 6•13 years ago
|
||
Target Milestone: --- → mozilla15
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•