Last Comment Bug 757425 - Compact Folders dialog has confusing keyboard shortcuts
: Compact Folders dialog has confusing keyboard shortcuts
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Database (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Thunderbird 15.0
Assigned To: :aceman
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-22 06:54 PDT by Chris AtLee [:catlee]
Modified: 2012-06-02 11:55 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (3.77 KB, patch)
2012-05-23 12:06 PDT, :aceman
iann_bugzilla: review+
mconley: review+
bugs: ui‑review+
Details | Diff | Review

Description Chris AtLee [:catlee] 2012-05-22 06:54:30 PDT
The Compact Folders dialog presents two buttons, "Cancel" and "Compact _N_ow". Half of the time I hit N by accident because I intend to say "No", which does the exact opposite of what I want.

http://people.mozilla.org/~catlee/sattap/e850d798.png
Comment 1 :aceman 2012-05-22 07:02:31 PDT
And what would you suggest as a better key? "C" is also not good :)
Bwinton, any ideas?
Comment 2 Blake Winton (:bwinton) (:☕️) (PTO 'til London. Find me there for quick answers!) 2012-05-22 13:18:30 PDT
Hah!  No, I'm on a Mac, so don't see the keyboard shortcuts, and I've gotten mired in that kind of discussion before.  I think this time you get to just pick a key, and ask mconley or andreasn for ui-review.  ;)

Thanks,
Blake.
Comment 3 :aceman 2012-05-23 03:13:00 PDT
Chris, your proposal?
I see the same "N" key on Windows.

I also wonder why "Cancel" does not have a key.

The code that shows this dialog is in /mailnews/base/util/nsMsgDBFolder.cpp and it will also affect Seamonkey.
Comment 4 Chris AtLee [:catlee] 2012-05-23 06:26:33 PDT
How about "_Y_es" and "_N_o"?
Comment 5 :aceman 2012-05-23 12:06:16 PDT
Created attachment 626539 [details] [diff] [review]
patch

I think such ambiguous button labels are explicitly unwanted.
Comment 6 Andreas Nilsson (:andreasn) 2012-05-29 06:32:01 PDT
how do I trigger this dialog? File > Compact folders just does it for me.
Comment 7 :aceman 2012-05-29 06:38:45 PDT
Set the limit in preferences to compact if it saves 1MB.
Then compose a msg with big attachment -> send later. Delete it from Outbox and Trash. It should prompt you.
Comment 8 Andreas Nilsson (:andreasn) 2012-05-29 07:35:55 PDT
To begin with, I don't understand why this dialog exists in the first place, apart from bothering people. But that could be another bug report ;)

In general it seems the policy for shortcuts is to go for the first letter if possible, and then go for second letters if not, from that point N makes sense.

I can see your mental connection to No though, so I could be all right with this change I guess.
Comment 9 :aceman 2012-05-29 07:42:11 PDT
Thanks.

The dialog is valuable. There are many problems with compaction running at inappropriate time, causing dataloss and other effects (at least I have the impression from watching bugzilla). So some people would like to see it and potentialy do not allow compact when not appropriate.
Who doesn't want that warning can easily disable it.
Comment 10 Andreas Nilsson (:andreasn) 2012-05-30 03:16:13 PDT
Comment on attachment 626539 [details] [diff] [review]
patch

Sure, lets go for this.
Comment 11 :aceman 2012-05-30 03:25:22 PDT
Comment on attachment 626539 [details] [diff] [review]
patch

I hope it is not necessary to change the string ID as localizations probably use other accesskey already.
Comment 12 Mike Conley (:mconley) - (Away until June 29th) 2012-05-30 13:14:06 PDT
Comment on attachment 626539 [details] [diff] [review]
patch

Review of attachment 626539 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks.
Comment 13 Mike Conley (:mconley) - (Away until June 29th) 2012-06-02 11:55:11 PDT
https://hg.mozilla.org/comm-central/rev/f0a4bcc87c91

Note You need to log in before you can comment on or make changes to this bug.