The default bug view has changed. See this FAQ.

Score Rush gets more choppy w/ igc

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: luke, Assigned: billm)

Tracking

(Blocks: 1 bug)

unspecified
mozilla15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:p2][games])

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 626050 [details]
incremental GC profile

With bug 750834 Score Rush is pretty smooth (17ms to render a frame).  The GC pauses are 35ms which is also pretty ok.  However, if you turn on igc, things are observably worse.

The per-frame profile attached also looks a lot worse: lots of recompilation, lots of interpreter time.  It almost looks like there is a bug involving igc where we throw away/recompile too much.

(To view the profile, you'll need to use billm's viewer.)
(Reporter)

Comment 1

5 years ago
Created attachment 626052 [details]
non-incremental GC profile

This is w/ igc turned off.  Looks much prettier.
(Assignee)

Updated

5 years ago
Attachment #626050 - Attachment mime type: text/plain → application/octet-stream
Blocks: 641025
(Reporter)

Updated

5 years ago
Attachment #626052 - Attachment mime type: text/plain → application/octet-stream
Blocks: 735099
No longer blocks: 641025
Whiteboard: games → [js:p2][games]
(Assignee)

Updated

5 years ago
Assignee: general → wmccloskey
(Assignee)

Comment 2

5 years ago
Created attachment 626537 [details] [diff] [review]
patch

We were setting the preserve flag in BeginMarkPhase, which is called once per incremental GC, and then unsetting it in ~AutoGCSession, which is called at the end of every slice. So in later slices, code was getting thrown away.
Attachment #626537 - Flags: review?(bhackett1024)
Attachment #626537 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ddbd1da2f9b
Target Milestone: --- → mozilla15
(Reporter)

Comment 4

5 years ago
Wow, that was fast!  With this patch, I can see the biggest GC slice (the first) is only 16.6ms and the whole frame renders in 28.4ms; big improvement over non-incremental.
https://hg.mozilla.org/mozilla-central/rev/9ddbd1da2f9b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.