B2G RIL: SIM Card Lock DOM Requests don't properly clean up

RESOLVED FIXED in mozilla15

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: marshall_law, Assigned: allstars)

Tracking

unspecified
mozilla15
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
The DOMRequests used to provide callbacks for the nsIDOMMobleConnection.getCardLock/setCardLock/unlockCardLock are not currently cleaning up the allocated DOM requests when status is sent back in ril_worker.js. 

The two examples I found were in dom/system/gonk/RILContentHelper.js (lines 317/325ish), where the use of this.getRequest(requestId) could be simply changed to this.takeRequest(requestId)
(Reporter)

Updated

5 years ago
Assignee: nobody → yhuang
Blocks: 710489
See Also: → bug 731786
Blocks: 731786
No longer blocks: 710489
(Assignee)

Comment 1

5 years ago
Created attachment 626310 [details] [diff] [review]
Patch
Attachment #626310 - Flags: review?(philipp)
(Assignee)

Comment 2

5 years ago
Comment on attachment 626310 [details] [diff] [review]
Patch

Thanks for Marshall to point this out.
Attachment #626310 - Flags: review?(philipp) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbfc7032b8dd

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/bbfc7032b8dd
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.