Last Comment Bug 757512 - B2G RIL: SIM Card Lock DOM Requests don't properly clean up
: B2G RIL: SIM Card Lock DOM Requests don't properly clean up
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: unspecified
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla15
Assigned To: Yoshi Huang[:allstars.chh]
:
Mentors:
Depends on:
Blocks: 731786
  Show dependency treegraph
 
Reported: 2012-05-22 10:26 PDT by Marshall Culpepper [:marshall_law]
Modified: 2012-05-24 09:19 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.47 KB, patch)
2012-05-22 20:40 PDT, Yoshi Huang[:allstars.chh]
philipp: review+
Details | Diff | Review

Description Marshall Culpepper [:marshall_law] 2012-05-22 10:26:46 PDT
The DOMRequests used to provide callbacks for the nsIDOMMobleConnection.getCardLock/setCardLock/unlockCardLock are not currently cleaning up the allocated DOM requests when status is sent back in ril_worker.js. 

The two examples I found were in dom/system/gonk/RILContentHelper.js (lines 317/325ish), where the use of this.getRequest(requestId) could be simply changed to this.takeRequest(requestId)
Comment 1 Yoshi Huang[:allstars.chh] 2012-05-22 20:40:40 PDT
Created attachment 626310 [details] [diff] [review]
Patch
Comment 2 Yoshi Huang[:allstars.chh] 2012-05-22 20:41:19 PDT
Comment on attachment 626310 [details] [diff] [review]
Patch

Thanks for Marshall to point this out.
Comment 3 Philipp von Weitershausen [:philikon] 2012-05-23 22:25:39 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbfc7032b8dd
Comment 4 Ed Morley [:emorley] 2012-05-24 09:19:55 PDT
https://hg.mozilla.org/mozilla-central/rev/bbfc7032b8dd

Note You need to log in before you can comment on or make changes to this bug.