Closed Bug 757512 Opened 12 years ago Closed 12 years ago

B2G RIL: SIM Card Lock DOM Requests don't properly clean up

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: marshall, Assigned: allstars.chh)

References

Details

Attachments

(1 file)

The DOMRequests used to provide callbacks for the nsIDOMMobleConnection.getCardLock/setCardLock/unlockCardLock are not currently cleaning up the allocated DOM requests when status is sent back in ril_worker.js. 

The two examples I found were in dom/system/gonk/RILContentHelper.js (lines 317/325ish), where the use of this.getRequest(requestId) could be simply changed to this.takeRequest(requestId)
Assignee: nobody → yhuang
Blocks: b2g-ril
See Also: → 731786
Blocks: 731786
No longer blocks: b2g-ril
Attached patch PatchSplinter Review
Attachment #626310 - Flags: review?(philipp)
Comment on attachment 626310 [details] [diff] [review]
Patch

Thanks for Marshall to point this out.
Attachment #626310 - Flags: review?(philipp) → review+
https://hg.mozilla.org/mozilla-central/rev/bbfc7032b8dd
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.