Last Comment Bug 757551 - Remove JS_ConstructObject* APIs
: Remove JS_ConstructObject* APIs
Status: RESOLVED FIXED
[js:t]
: dev-doc-complete
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-22 11:45 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2012-06-06 08:45 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (6.96 KB, patch)
2012-05-24 18:51 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
no flags Details | Diff | Review
Unbitrotted (6.96 KB, patch)
2012-05-31 09:56 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
dmandelin: review+
Details | Diff | Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2012-05-22 11:45:07 PDT
These methods don't act like anything people would be familiar with (new Ctor(...), more specifically).  They're only used by E4X internals in all of Mozilla.  We should remove them.

I sent a query out to the newgroup to see if anyone's using these, and if so how to address any use case they might have (however awkwardly) been fulfilling:

https://groups.google.com/forum/?fromgroups#!topic/mozilla.dev.tech.js-engine/5xqxa2IAOoQ
Comment 1 Jeff Walden [:Waldo] (remove +bmo to email) 2012-05-24 18:51:55 PDT
Created attachment 627066 [details] [diff] [review]
Patch

Some people are using these APIs, and I'm still working through trying to migrate them to something better (probably JS_New for the most part).  Just posting this to get it in the database for now...
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2012-05-31 09:56:57 PDT
Created attachment 628783 [details] [diff] [review]
Unbitrotted

One response in the newsgroups we determined could be worked through with JS_New.  The other response mentioned they used the methods but never responded to my response asking if JS_New wouldn't work to address them.  So going by that, one embedder has a reasonable workaround, and another hasn't said he doesn't.

At some point you have to move forward, so let's put this up for review now.  (I sent one last newsgroup ping noting I was putting the patch up for review, for anyone who missed the earlier bits of the thread.)
Comment 4 Ed Morley [:emorley] 2012-06-06 08:45:01 PDT
https://hg.mozilla.org/mozilla-central/rev/9fa952692a8c

Note You need to log in before you can comment on or make changes to this bug.