Closed Bug 757594 Opened 8 years ago Closed 8 years ago

Implicit Makefile rule changes in bug 748001 broke libvpx's obj_int_extract

Categories

(Core :: Audio/Video, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: derf, Assigned: derf)

References

Details

Attachments

(1 file)

Bug 748001 got rid of some implicit rules that media/libvpx/Makefile.in was relying on to make the obj_int_extract approach to extracting C struct offsets for the libvpx asm work. We didn't notice because
a) the decoder only needs these offsets on ARM, and ARM always uses gcc, which does this a much better way (without obj_int_extract), and
b) the encoder is not built by default.
Assignee: nobody → tterribe
Blocks: 748001
Status: NEW → ASSIGNED
OS: Linux → Windows XP
Hardware: x86_64 → x86
Try results with encoder (and error concealment) enabled incoming: https://tbpl.mozilla.org/?tree=Try&rev=e2864eec0017
Attachment #626197 - Flags: review?(mh+mozilla)
https://hg.mozilla.org/integration/mozilla-inbound/rev/384f2d1f7b49
Flags: in-testsuite-
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/384f2d1f7b49
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.