Closed Bug 757600 Opened 12 years ago Closed 12 years ago

Ogg Opus header version bump

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: rillian, Assigned: rillian)

Details

Attachments

(1 file, 1 obsolete file)

Update the Opus version field parser
2.64 KB, patch
rillian
: review+
Details | Diff | Splinter Review 
The Ogg Opus header had a version bump recently, with no other changes. We're now supposed to accept any stream with version > 16, i.e. when the high four bits are zero.
(In reply to Ralph Giles (:rillian) from comment #0)
> We're now supposed to accept any stream with version > 16, i.e. when the

< 16, to be clear.
Proposed fix.
Assignee: nobody → giles
Whiteboard: [autoland-try:-b do -p all -u mochitest-1 -t none]
Attachment #626170 - Flags: review?(cpearce)
Whiteboard: [autoland-try:-b do -p all -u mochitest-1 -t none] → [autoland-in-queue]
Comment on attachment 626170 [details] [diff] [review]
Update the Opus version field parser

Review of attachment 626170 [details] [diff] [review]:
-----------------------------------------------------------------

Since mVersion is only used once, just store it in a local variable rather than adding a datafield to nsOpusState.

r+ with that change.
Attachment #626170 - Flags: review?(cpearce) → review+
Updated patch addressing review comments.
Attachment #626247 - Flags: review+
Attachment #626170 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/f93a650e8a8c
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [autoland-in-queue]
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/f93a650e8a8c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: