Ogg Opus header version bump

RESOLVED FIXED in mozilla15

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: rillian, Assigned: rillian)

Tracking

Trunk
mozilla15
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The Ogg Opus header had a version bump recently, with no other changes. We're now supposed to accept any stream with version > 16, i.e. when the high four bits are zero.
(In reply to Ralph Giles (:rillian) from comment #0)
> We're now supposed to accept any stream with version > 16, i.e. when the

< 16, to be clear.
(Assignee)

Comment 2

5 years ago
Created attachment 626170 [details] [diff] [review]
Update the Opus version field parser

Proposed fix.
Assignee: nobody → giles
(Assignee)

Updated

5 years ago
Whiteboard: [autoland-try:-b do -p all -u mochitest-1 -t none]
(Assignee)

Updated

5 years ago
Attachment #626170 - Flags: review?(cpearce)

Updated

5 years ago
Whiteboard: [autoland-try:-b do -p all -u mochitest-1 -t none] → [autoland-in-queue]
Comment on attachment 626170 [details] [diff] [review]
Update the Opus version field parser

Review of attachment 626170 [details] [diff] [review]:
-----------------------------------------------------------------

Since mVersion is only used once, just store it in a local variable rather than adding a datafield to nsOpusState.

r+ with that change.
Attachment #626170 - Flags: review?(cpearce) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 626247 [details] [diff] [review]
Update the Opus version field parser

Updated patch addressing review comments.
Attachment #626247 - Flags: review+
(Assignee)

Updated

5 years ago
Attachment #626170 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/f93a650e8a8c
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [autoland-in-queue]
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/f93a650e8a8c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.