Closed
Bug 75764
Opened 25 years ago
Closed 25 years ago
nsNativeComponentLoader::AutoRegisterComponent contains non-static array
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbradley, Assigned: kandrot)
Details
Attachments
(1 file)
|
694 bytes,
patch
|
Details | Diff | Splinter Review |
nsNativeComponentLoader::AutoRegisterComponent contains a non-static array of
strings that should be static as it is read-only. I've attached a patch
(Assuming I do it correctly) that contains the update also made the pointers
themselves constant.
|
Reporter | |
Comment 1•25 years ago
|
||
|
|
||
Updated•25 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
||
Comment 2•25 years ago
|
||
sr=jband. Ooh, const pointers *and* pointees. Looks good to me.
|
|
||
Comment 3•25 years ago
|
||
shaver: wanna batch this in with your other xpcom/components changes?
kandrot: You're expected to at least take notice and acknowledge contributor
patches within a reasonable amount of time. Even if you don't want to be
bothered with actually doing anything, you have to at least *say* so.
|
|
Reporter | |
Updated•25 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•25 years ago
|
||
I have added this to the patch to make a static build (a whole lot of "static"
being added to remove unneeded global refs). Will be checked in this week
(probably tonight).
Thank you for the patch.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•