757667 - Clean up Proxy tracing

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

This simplifies some of the proxy tracing. It removes the trace() method, which was never really used for anything except tracing the private slot, which we do anyway in proxy_TraceObject.

It also marks the JSSLOT_PROXY_CALL slot from markCrossCompartmentWrappers. As far as I can tell, this slot, when it exists, is always the same as the JSSLOT_PROXY_PRIVATE slot. So there isn't really a bug here. But it's better to mark it anyway, and it will help moving GC.

Comment 1

[Terrence Cole [:terrence]]

Comment on attachment 626250 [details] [diff] [review]
patch

Review of attachment 626250 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a0351f94b71

Comment 3

[Ryan VanderMeulen [:RyanVM]]

This was backed out for causing bustage on all platforms. Please run your patch through Try before landing it again.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee4625163f87

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/265ea2a9d169

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/265ea2a9d169