Last Comment Bug 757667 - Clean up Proxy tracing
: Clean up Proxy tracing
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
-- normal with 1 vote (vote)
: mozilla15
Assigned To: Bill McCloskey (:billm)
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2012-05-22 16:52 PDT by Bill McCloskey (:billm)
Modified: 2012-05-25 08:35 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (9.30 KB, patch)
2012-05-22 16:52 PDT, Bill McCloskey (:billm)
terrence.d.cole: review+
Details | Diff | Splinter Review

Description User image Bill McCloskey (:billm) 2012-05-22 16:52:22 PDT
Created attachment 626250 [details] [diff] [review]

This simplifies some of the proxy tracing. It removes the trace() method, which was never really used for anything except tracing the private slot, which we do anyway in proxy_TraceObject.

It also marks the JSSLOT_PROXY_CALL slot from markCrossCompartmentWrappers. As far as I can tell, this slot, when it exists, is always the same as the JSSLOT_PROXY_PRIVATE slot. So there isn't really a bug here. But it's better to mark it anyway, and it will help moving GC.
Comment 1 User image Terrence Cole [:terrence] 2012-05-22 17:32:24 PDT
Comment on attachment 626250 [details] [diff] [review]

Review of attachment 626250 [details] [diff] [review]:

Comment 3 User image Ryan VanderMeulen [:RyanVM] 2012-05-23 18:19:19 PDT
This was backed out for causing bustage on all platforms. Please run your patch through Try before landing it again.
Comment 5 User image Ed Morley [:emorley] 2012-05-25 08:35:07 PDT

Note You need to log in before you can comment on or make changes to this bug.