Clean up Proxy tracing

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 626250 [details] [diff] [review]
patch

This simplifies some of the proxy tracing. It removes the trace() method, which was never really used for anything except tracing the private slot, which we do anyway in proxy_TraceObject.

It also marks the JSSLOT_PROXY_CALL slot from markCrossCompartmentWrappers. As far as I can tell, this slot, when it exists, is always the same as the JSSLOT_PROXY_PRIVATE slot. So there isn't really a bug here. But it's better to mark it anyway, and it will help moving GC.
Attachment #626250 - Flags: review?(terrence)
Comment on attachment 626250 [details] [diff] [review]
patch

Review of attachment 626250 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #626250 - Flags: review?(terrence) → review+
Whiteboard: [js:t]
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a0351f94b71
Target Milestone: --- → mozilla15
This was backed out for causing bustage on all platforms. Please run your patch through Try before landing it again.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee4625163f87
Target Milestone: mozilla15 → ---
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/265ea2a9d169
Target Milestone: --- → mozilla15

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/265ea2a9d169
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.