The default bug view has changed. See this FAQ.

make nsIPresShell::GetLinkLocation faster

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 1 bug, {access})

unspecified
mozilla15
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

11.71 KB, patch
tbsaunde
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 626258 [details] [diff] [review]
patch

6% we spend for it (for bug 732872 case), most of time is spent for URI computation for nsHTMLAnchorElement.

the nsHTMLAnchorElement fix isn't nice but probably ok (if all this code is going to be reworked one day).
Attachment #626258 - Flags: review?(bzbarsky)
Comment on attachment 626258 [details] [diff] [review]
patch

Is there a reason this isn't an nsContentUtils method?  And if it really always takes an element, the argument should be Element.

Past that, I guess this is OK...
(Assignee)

Comment 2

5 years ago
Created attachment 626318 [details] [diff] [review]
patch2
Attachment #626258 - Attachment is obsolete: true
Attachment #626258 - Flags: review?(bzbarsky)
Attachment #626318 - Flags: review?(bzbarsky)
(Assignee)

Updated

5 years ago
Attachment #626318 - Flags: review?(trev.saunders)
Attachment #626318 - Flags: review?(trev.saunders) → review+
Comment on attachment 626318 [details] [diff] [review]
patch2

Er, also please nuke the DEBUG_dr chunk and the no-op StripChars business.

r=me with that.
Attachment #626318 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0c9c6e916db
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/f0c9c6e916db
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.