Last Comment Bug 757670 - make nsIPresShell::GetLinkLocation faster
: make nsIPresShell::GetLinkLocation faster
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla15
Assigned To: alexander :surkov
: alexander :surkov
Depends on:
Blocks: 732872
  Show dependency treegraph
Reported: 2012-05-22 17:06 PDT by alexander :surkov
Modified: 2012-05-24 09:18 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (8.45 KB, patch)
2012-05-22 17:06 PDT, alexander :surkov
no flags Details | Diff | Splinter Review
patch2 (11.71 KB, patch)
2012-05-22 21:34 PDT, alexander :surkov
bzbarsky: review+
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review

Description User image alexander :surkov 2012-05-22 17:06:09 PDT
Created attachment 626258 [details] [diff] [review]

6% we spend for it (for bug 732872 case), most of time is spent for URI computation for nsHTMLAnchorElement.

the nsHTMLAnchorElement fix isn't nice but probably ok (if all this code is going to be reworked one day).
Comment 1 User image Boris Zbarsky [:bz] (still a bit busy) 2012-05-22 20:17:21 PDT
Comment on attachment 626258 [details] [diff] [review]

Is there a reason this isn't an nsContentUtils method?  And if it really always takes an element, the argument should be Element.

Past that, I guess this is OK...
Comment 2 User image alexander :surkov 2012-05-22 21:34:14 PDT
Created attachment 626318 [details] [diff] [review]
Comment 3 User image Boris Zbarsky [:bz] (still a bit busy) 2012-05-22 22:01:16 PDT
Comment on attachment 626318 [details] [diff] [review]

Er, also please nuke the DEBUG_dr chunk and the no-op StripChars business.

r=me with that.
Comment 5 User image Ed Morley [:emorley] 2012-05-24 09:18:29 PDT

Note You need to log in before you can comment on or make changes to this bug.