The default bug view has changed. See this FAQ.

IonMonkey: Values should be at least word aligned on ARM

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mjrosenb, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 626260 [details] [diff] [review]
/home/mrosenberg/patches/fixAlignment-r0.patch

I noticed this while running on my Nexus-S a few weeks ago, then got derailed when my desktop bit the dust.
(gdb) x/i $pc
=> 0x5b00ba8c:	strd	r2, r3, [r1]
(gdb) p/x $r1
$1 = 0x5e487fd1

I am not sure why there aren't any debug symbols, but this is in the process of copying data into the constant table attached to every script, and this data is misaligned, so it crashes.
Attachment #626260 - Flags: review?(sstangl)
Comment on attachment 626260 [details] [diff] [review]
/home/mrosenberg/patches/fixAlignment-r0.patch

Review of attachment 626260 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/Ion.cpp
@@ +398,5 @@
>      cacheEntries_(0),
>      refcount_(0)
>  {
>  }
> +static const int DataAlignment = 4;

nit: needs newlines around this line.
Attachment #626260 - Flags: review?(sstangl) → review+
(Reporter)

Comment 2

5 years ago
landed: http://hg.mozilla.org/projects/ionmonkey/rev/aff52d7f5924
looks like this short patch got lost amongst a large number that I committed that day.
(Reporter)

Comment 3

5 years ago
And actually closing the issue.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.