The default bug view has changed. See this FAQ.

support unitless values for mpadded attributes

RESOLVED FIXED in mozilla15

Status

()

Core
MathML
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: karlt, Assigned: fredw)

Tracking

({dev-doc-complete, regression})

Other Branch
mozilla15
x86_64
All
dev-doc-complete, regression
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
The regular expression for mpadded attributes in MathML 3.0 First Edition required units, but this was inconsistent with what was implied in the text.

The editor's draft for the Second Edition has now updated the regular expression to allow unitless values, which is what was intended and is consistent with the text.

http://lists.w3.org/Archives/Public/www-math/2012May/0027.html

Bug 677036 removed the special case for "0" in mpadded attributes, so that part of this bug is a regression.  Other unitless values have not been previously supported in Gecko.
(Reporter)

Updated

5 years ago
(Reporter)

Updated

5 years ago
Keywords: regression
(Assignee)

Comment 1

5 years ago
I think we should really only support unitless "0" as in CSS:

http://www.w3.org/TR/css3-values/#lengths

See my comment here:
http://lists.w3.org/Archives/Public/www-math/2012May/0028.html
(Assignee)

Updated

5 years ago
Summary: support unitless values for mapped attributes → support unitless values for mpadded attributes
(Assignee)

Comment 2

5 years ago
Created attachment 626941 [details] [diff] [review]
Patch V1

This patch should restore support for the "0" case and treats other unitless values as a multiple of the base size.
Assignee: nobody → fred.wang
Status: NEW → ASSIGNED
Attachment #626941 - Flags: review?(karlt)
(Reporter)

Comment 3

5 years ago
Comment on attachment 626941 [details] [diff] [review]
Patch V1

>+      aCSSValue.SetPercentValue(floatValue);

It probably doesn't make any difference in practice, but it would be more consistent to use SetFloatValue(floatValue, eCSSUnit_Number).

I'm also happy if you only restore the "0" until the MathML WG makes a decision.
You made some good points against unitless values, but my guess is that they are unlikely to make a change if the intention was to allow unitless values.
Attachment #626941 - Flags: review?(karlt) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 627186 [details] [diff] [review]
Patch V2
Attachment #626941 - Attachment is obsolete: true
Attachment #627186 - Flags: review?(karlt)
(Assignee)

Updated

5 years ago
Keywords: dev-doc-needed
(Reporter)

Updated

5 years ago
Attachment #627186 - Flags: review?(karlt) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/34af06cc57f6
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/34af06cc57f6
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
A note on this topic has been added to
https://developer.mozilla.org/en-US/docs/Firefox_15_for_developers#MathML

We probably don't need more docs here (see bug 677036#c30 ff).
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.