Closed
Bug 757703
Opened 12 years ago
Closed 12 years ago
support unitless values for mpadded attributes
Categories
(Core :: MathML, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: karlt, Assigned: fredw)
References
()
Details
(Keywords: dev-doc-complete, regression)
Attachments
(1 file, 1 obsolete file)
2.17 KB,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
The regular expression for mpadded attributes in MathML 3.0 First Edition required units, but this was inconsistent with what was implied in the text. The editor's draft for the Second Edition has now updated the regular expression to allow unitless values, which is what was intended and is consistent with the text. http://lists.w3.org/Archives/Public/www-math/2012May/0027.html Bug 677036 removed the special case for "0" in mpadded attributes, so that part of this bug is a regression. Other unitless values have not been previously supported in Gecko.
Reporter | ||
Updated•12 years ago
|
Reporter | ||
Updated•12 years ago
|
Keywords: regression
Assignee | ||
Comment 1•12 years ago
|
||
I think we should really only support unitless "0" as in CSS: http://www.w3.org/TR/css3-values/#lengths See my comment here: http://lists.w3.org/Archives/Public/www-math/2012May/0028.html
Assignee | ||
Updated•12 years ago
|
Summary: support unitless values for mapped attributes → support unitless values for mpadded attributes
Assignee | ||
Comment 2•12 years ago
|
||
This patch should restore support for the "0" case and treats other unitless values as a multiple of the base size.
Reporter | ||
Comment 3•12 years ago
|
||
Comment on attachment 626941 [details] [diff] [review] Patch V1 >+ aCSSValue.SetPercentValue(floatValue); It probably doesn't make any difference in practice, but it would be more consistent to use SetFloatValue(floatValue, eCSSUnit_Number). I'm also happy if you only restore the "0" until the MathML WG makes a decision. You made some good points against unitless values, but my guess is that they are unlikely to make a change if the intention was to allow unitless values.
Attachment #626941 -
Flags: review?(karlt) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #626941 -
Attachment is obsolete: true
Attachment #627186 -
Flags: review?(karlt)
Assignee | ||
Updated•12 years ago
|
Keywords: dev-doc-needed
Reporter | ||
Updated•12 years ago
|
Attachment #627186 -
Flags: review?(karlt) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/34af06cc57f6
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 7•12 years ago
|
||
A note on this topic has been added to https://developer.mozilla.org/en-US/docs/Firefox_15_for_developers#MathML We probably don't need more docs here (see bug 677036#c30 ff).
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•